[shelly] Fix UNI support up to three DS18B20 sensors #15530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order Signed-off-by: Anton Hattendorf <anton@hattendoerfer.de>
lsiepel
changed the title
|
@markus7017: could you please review ? |
lolodomo
reviewed
Sep 9, 2023
Comment on lines
+131
to
+132
| if (json.contains("\"ext_temperature\":{\"0\":[{") || json.contains("\"ext_temperature\":{\"1\":[{") | ||
| || json.contains("\"ext_temperature\":{\"2\":[{")) { |
There was a problem hiding this comment.
Wouldn't this be sufficient ?
if (json.contains("\"ext_temperature\":{\"")) {
There was a problem hiding this comment.
I can't tell.
I assume there was a reason, the JSON string is checked including the array index. So I just added the two other possible cases, but keeping as close to the original condition as possible.
There was a problem hiding this comment.
Let's wait for @markus7017 feedback
|
@markus7017 : are you there ? |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh4-runs-out-of-memory/148699/66 |
|
LGTM |
lolodomo
approved these changes
Oct 8, 2023
pat-git023
pushed a commit
to pat-git023/openhab-addons
that referenced
this pull request
Oct 13, 2023
… in order (openhab#15530) Signed-off-by: Anton Hattendorf <anton@hattendoerfer.de>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
… in order (openhab#15530) Signed-off-by: Anton Hattendorf <anton@hattendoerfer.de>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
… in order (openhab#15530) Signed-off-by: Anton Hattendorf <anton@hattendoerfer.de> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
… in order (openhab#15530) Signed-off-by: Anton Hattendorf <anton@hattendoerfer.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the Shelly UNI a small fix needs to be applied to the JSON that is received form the device. When two or more temperature sensors are attached, the array is not sorted and the sensor "1" is first, causes the string replacement to fail.
With this patch all tree possible variants are checked, so that the JSON fix is applied for all possible sortings.
Note: The Shelly UNI supports only up to three DS18B20.
Testing
Here is the build artifact:
https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.shelly/4.1.0-SNAPSHOT/org.openhab.binding.shelly-4.1.0-SNAPSHOT.jar
Installed and tested on my local system - Shelly gets
ONLINEand all three DS18B20 are detected and working.Note: This is my first pull request, I hope I'll got everything correct.