Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tellstick] Fix local bridge handler update #15596

Merged
merged 1 commit into from Sep 25, 2023
Merged

[tellstick] Fix local bridge handler update #15596

merged 1 commit into from Sep 25, 2023

Conversation

aviborg
Copy link
Contributor

@aviborg aviborg commented Sep 13, 2023 •
edited

Fixes #15592

@aviborg aviborg requested a review from a team as a code owner September 13, 2023 19:11
lsiepel
lsiepel requested changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

.../src/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalDeviceDTO.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalDeviceDTO.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalSensorDTO.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalSensorDTO.java Outdated Show resolved Hide resolved
lsiepel
lsiepel approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviborg
Copy link
Contributor Author

aviborg commented Sep 22, 2023

How do you get a maintaner to approve a bugfix like this? Seems like no one cares about this binding anymore.
@kaikreuzer

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/remove-bindings-not-maintained-anymore/149833/1

@lsiepel
Copy link
Contributor

lsiepel commented Sep 23, 2023

How do you get a maintaner to approve a bugfix like this? Seems like no one cares about this binding anymore. @kaikreuzer

Resources are limited, but eventually it will be picked up by a maintainer, i'm sure. There are 150+ PR's at the moment and the mayority is older then a week like this one, so please give them some time to advance.

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Sep 23, 2023
@maniac103
Copy link
Contributor

That last force push added some commits which very likely are not supposed to be in this PR.

@aviborg
Fix sensor and device update
c97d2f2 
Signed-off-by: AndreasV <andreas.viborg@gmail.com>
@aviborg
Copy link
Contributor Author

aviborg commented Sep 24, 2023

Had to fix a missing signoff, going back a few commits. The rebase didn't work out as I wanted, messed up. Commit c97d2f2 is according to all historic comments.

maniac103
maniac103 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@maniac103 maniac103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as far as I can tell.

lolodomo
lolodomo approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 9c22b7b into openhab:main Sep 25, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Sep 25, 2023
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
@aviborg @Pshatsillo
Fix sensor and device update (openhab#15596)
506aa1f 
Signed-off-by: AndreasV <andreas.viborg@gmail.com>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@aviborg @pat-git023
Fix sensor and device update (openhab#15596)
7aaddad 
Signed-off-by: AndreasV <andreas.viborg@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@aviborg @querdenker2k
Fix sensor and device update (openhab#15596)
43a7442 
Signed-off-by: AndreasV <andreas.viborg@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@aviborg @querdenker2k
Fix sensor and device update (openhab#15596)
9fcd5df 
Signed-off-by: AndreasV <andreas.viborg@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@aviborg @austvik
Fix sensor and device update (openhab#15596)
034cdcb 
Signed-off-by: AndreasV <andreas.viborg@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@maniac103 maniac103 maniac103 approved these changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[tellstick] Existing sensors and device are added as new for every update on local bridge
5 participants
@aviborg @openhab-bot @lsiepel @maniac103 @lolodomo