New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[romyrobot][WIP] Initial contribution #15738
base: main
Are you sure you want to change the base?
Conversation
67e414d
to
01d64f6
Compare
e32b9ae
to
0c0f6fd
Compare
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
0c0f6fd
to
d25a6cd
Compare
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
implemented loading of maps Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
implemented loading of maps Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
d25a6cd
to
9d7de4c
Compare
<parent> | ||
<groupId>org.openhab.addons.bundles</groupId> | ||
<artifactId>org.openhab.addons.reactor.bundles</artifactId> | ||
<version>4.1.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<version>4.1.0-SNAPSHOT</version> | |
<version>4.2.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is a WIP, i had a very quick scan and did not do an extensive review.
Just as a reminder; also run the i18n pluging, write the readme contents and adjust all the loggers to the right level if even needed to log at all.
</channel-type> | ||
<channel-type id="selectedmap"> | ||
<item-type>String</item-type> | ||
<label>Seleted Map</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<label>Seleted Map</label> | |
<label>Selected Map</label> |
</channel-type> | ||
<channel-type id="battery"> | ||
<item-type>Number</item-type> | ||
<label>Battery</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<label>Battery</label> | |
<label>Battery State</label> |
<label>Suction Mode</label> | ||
<description>Choose an available suction mode</description> | ||
<state> | ||
<options> <!--available: 1=Normal,2=Silent,3=Intensive,0=Default,4=Super Silent --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<options> <!--available: 1=Normal,2=Silent,3=Intensive,0=Default,4=Super Silent --> | |
<options> |
<label>Cleaning Strategy</label> | ||
<description>Choose an available cleaning strategy</description> | ||
<state> | ||
<options> <!--available: 1=Normal,2=WallsCorners,3=Deep,4=Default --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<options> <!--available: 1=Normal,2=WallsCorners,3=Deep,4=Default --> | |
<options> |
<default>5</default> | ||
<advanced>true</advanced> | ||
</parameter> | ||
<parameter name="timeout" type="integer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter allready exists
<type>binding</type> | ||
<name>romyRobot Binding</name> | ||
<description>This is the binding for romyRobot.</description> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add connection tag
ROMY robot binding
Binding for your romy robot vacuum cleaner
Description
https://community.openhab.org/t/romy-robot-integration-via-http-binding-austrian-vacuum-robot-highly-recommended/143307