Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[romyrobot][WIP] Initial contribution #15738

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

xeniter
Copy link

@xeniter xeniter commented Oct 11, 2023

@xeniter xeniter requested a review from a team as a code owner October 11, 2023 12:07
@xeniter xeniter marked this pull request as draft October 11, 2023 12:13
@jlaur jlaur changed the title - [romyrobot][WIP] Initial contribution [romyrobot][WIP] Initial contribution Oct 11, 2023
@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Oct 11, 2023
@xeniter xeniter force-pushed the romyrobot-binding branch 2 times, most recently from 67e414d to 01d64f6 Compare October 18, 2023 12:20
@xeniter xeniter force-pushed the romyrobot-binding branch 4 times, most recently from e32b9ae to 0c0f6fd Compare November 3, 2023 13:45
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/romy-robot-integration-via-http-binding-austrian-vacuum-robot-highly-recommended/143307/3

@xeniter xeniter marked this pull request as ready for review November 3, 2023 13:51
wzbfyb and others added 17 commits November 29, 2023 14:46
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
implemented loading of maps

Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
wzbfyb and others added 27 commits November 29, 2023 14:46
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
implemented loading of maps

Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Bernhard Kreuz <bernhard@kreuz.wien>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
Signed-off-by: Manuel Dipolt <manuel@linux-home.at>
<parent>
<groupId>org.openhab.addons.bundles</groupId>
<artifactId>org.openhab.addons.reactor.bundles</artifactId>
<version>4.1.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>4.1.0-SNAPSHOT</version>
<version>4.2.0-SNAPSHOT</version>

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is a WIP, i had a very quick scan and did not do an extensive review.

Just as a reminder; also run the i18n pluging, write the readme contents and adjust all the loggers to the right level if even needed to log at all.

</channel-type>
<channel-type id="selectedmap">
<item-type>String</item-type>
<label>Seleted Map</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<label>Seleted Map</label>
<label>Selected Map</label>

</channel-type>
<channel-type id="battery">
<item-type>Number</item-type>
<label>Battery</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<label>Battery</label>
<label>Battery State</label>

<label>Suction Mode</label>
<description>Choose an available suction mode</description>
<state>
<options> <!--available: 1=Normal,2=Silent,3=Intensive,0=Default,4=Super Silent -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<options> <!--available: 1=Normal,2=Silent,3=Intensive,0=Default,4=Super Silent -->
<options>

<label>Cleaning Strategy</label>
<description>Choose an available cleaning strategy</description>
<state>
<options> <!--available: 1=Normal,2=WallsCorners,3=Deep,4=Default -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<options> <!--available: 1=Normal,2=WallsCorners,3=Deep,4=Default -->
<options>

<default>5</default>
<advanced>true</advanced>
</parameter>
<parameter name="timeout" type="integer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter allready exists

<type>binding</type>
<name>romyRobot Binding</name>
<description>This is the binding for romyRobot.</description>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add connection tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants