-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade json to 20231013 #15745
Upgrade json to 20231013 #15745
Conversation
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur: openhabcloud is certainly used by almost every user. Any idea what exactly could impact this change or what to test WRT openhabcloud ? |
@weymann : you approved after testing which one of the impacted bindings ? |
It's used only by this class it seems, but in many places: Lines 43 to 44 in 7313415
Best would probably be if someone would be willing to install it in a production system and let it run for a while. I don't use the binding personally (I'm using VPN for remote access through the openHAB app and Pushover for notifications). I wouldn't expect any issues when looking at the release notes, but you never really know. I think the binding would be quite broken in general if the new version is bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and let's give it a test. 🚀
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Release notes:
Fixed vulnerabilities:
Library:
See also dependabot alerts.
Release notes
Sourced from org.json:json's releases.
Yet untested, since I don't use any of those bindings. I'm hoping binding maintainers can help out.