Upgrade json to 20231013

[jlaur]

Release notes:

• https://github.com/stleary/JSON-java/releases/tag/20230618
• https://github.com/stleary/JSON-java/releases/tag/20231013

Fixed vulnerabilities:

• CVE-2023-5072

Library:

• https://mvnrepository.com/artifact/org.json/json/20231013

See also dependabot alerts.

Release notes

Sourced from org.json:json's releases.

20231013

Pull Request	Description
#793	Reverted #761
#792	update the docs for release 20231013
#783	optLong vs getLong inconsistencies
#782	Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows
#779	add validity check for JSONObject constructors
#778	Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows
#776	Update [JUnit to version 4.13.2
#774	Removing unneeded synchronization
#773	Add optJSONArray method to JSONObject with a default value
#772	Disallow nested objects and arrays as keys in objects
#779	Unit test cleanup
#769	Addressed Java 17 compile warnings
#764	Update CodeQL action version
#761	Add module-info
#759	JSON parsing should detect embedded
#753	Updated new object methods
#752	Fixes possible unit test bug when compiling/testing on Windows

20230618

Pull Request	Description
#749	Prep for release 20230618
#740	Fixed Flaky Tests Caused by JSON permutations
#734	Fixed Flaky Tests Caused by JSON permutations
#733	JSONTokener implemented java.io.Closeable
#731	Removing commented out code in JSONObject optDouble()
#729	Refactor ParserConfiguration class hierarchy

Yet untested, since I don't use any of those bindings. I'm hoping binding maintainers can help out.

[weymann]

LGTM

[lolodomo]

@jlaur: openhabcloud is certainly used by almost every user. Any idea what exactly could impact this change or what to test WRT openhabcloud ?

[lolodomo]

@weymann : you approved after testing which one of the impacted bindings ?

[jlaur]

openhabcloud is certainly used by almost every user. Any idea what exactly could impact this change or what to test WRT openhabcloud ?

It's used only by this class it seems, but in many places:

openhab-addons/bundles/org.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/internal/CloudClient.java

Lines 43 to 44 in 7313415

	import org.json.JSONException;
	import org.json.JSONObject;

Best would probably be if someone would be willing to install it in a production system and let it run for a while. I don't use the binding personally (I'm using VPN for remote access through the openHAB app and Pushover for notifications).

I wouldn't expect any issues when looking at the release notes, but you never really know. I think the binding would be quite broken in general if the new version is bad.

[wborn]

Thanks and let's give it a test. 🚀