[mqtt.homie] build a per-thing thing type #15893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise channel groups don't show up correctly in MainUI (in actual groups with a heading). Note that this is completely backwards compatible - even though Things change their ThingTypeUID after they're created, their UID does _not_ change, so no channel UIDs change either. A happy consequence of building ChannelDefinitions for the ThingType is that custom ChannelTypes are no longer necessary - the only variable parts are labels and state/command descriptions, which are overridden by the ThingType's ChannelDefinition and the DynamicStateDescriptionProvider respectively. This can greatly increase responsiveness of MainUI if you have many Homie things with many channels. My /rest/channel-types response went from 2.6MB to 175KB. Since the full list of thing types is never queried, there's no corresponding increase anywhere else. Signed-off-by: Cody Cutrer <cody@cutrer.us>
|
Build failed in tests. |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
added
the
enhancement
|
Anything pending before this can be merged? |
|
ping @lolodomo. I know this is a large PR, but I've got additional commits waiting for this to merge, including a similar change for Home Assistant, and then on top of those two using AbstractStorageBasedTypeProvider so that both Homie and Home Assistant things don't have the two minute delay before going online after an openHAB restart. |
lsiepel
approved these changes
Apr 1, 2024
|
Yes, I can confirm that this is fully backwards compatible. I've been running this for over a year in my production environment at this point, and two others for nearly 6 months. |
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
* [mqtt.homie] build a per-thing thing type Signed-off-by: Cody Cutrer <cody@cutrer.us>
adr001db
pushed a commit
to adr001db/openhab-addons
that referenced
this pull request
May 12, 2024
* [mqtt.homie] build a per-thing thing type Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise channel groups don't show up correctly in MainUI (in actual groups with a heading).
Note that this is completely backwards compatible - even though Things change their ThingTypeUID after they're created, their UID does not change, so no channel UIDs change either.
A happy consequence of building ChannelDefinitions for the ThingType is that custom ChannelTypes are no longer necessary - the only variable parts are labels and state/command descriptions, which are overridden by the ThingType's ChannelDefinition and the DynamicStateDescriptionProvider respectively. This can greatly increase responsiveness of MainUI if you have many Homie things with many channels. My /rest/channel-types response went from 2.6MB to 175KB. Since the full list of thing types is never queried, there's no corresponding increase anywhere else.
Fixes #9728, #11704