Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensorpush] Initial contribution #15933

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bobadair
Copy link
Member

SensorPush sells a line of battery-powered wireless sensors that, depending on the model, provide data on temperature, relative humidity, barometric pressure, dew point, and vapor pressure deficit (VPD). The sensors communicate using Bluetooth LE. While they can be used directly via Bluetooth, when multiple sensors are in use they are typically configured to relay data to a cloud service via the G1 WiFi Gateway. This binding retrieves sensor data from the SensorPush Gateway Cloud using a published API.

This is a replacement for PR #10310.

Signed-off-by: Bob Adair <bob.github@att.net>
@bobadair bobadair added the new binding If someone has started to work on a binding. For a new binding PR. label Nov 20, 2023
@bobadair bobadair requested a review from a team as a code owner November 20, 2023 17:29
Signed-off-by: Bob Adair <bob.github@att.net>
Signed-off-by: Bob Adair <bob.github@att.net>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sensorpush-binding/118824/10

Signed-off-by: Bob Adair <bob.github@att.net>
@lsiepel
Copy link
Contributor

lsiepel commented Dec 14, 2023

Did you fix all the review comments from the previous PR, like the textual config and oauth? Can you also fix the DCO?

<parent>
<groupId>org.openhab.addons.bundles</groupId>
<artifactId>org.openhab.addons.reactor.bundles</artifactId>
<version>4.1.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>4.1.0-SNAPSHOT</version>
<version>4.2.0-SNAPSHOT</version>

@lsiepel
Copy link
Contributor

lsiepel commented Apr 27, 2024

@bobadair are you able to fix the DCO and build? I might review this PR, just checking if you are able to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants