Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Enable home being both energy and security #16026

Merged
merged 1 commit into from Dec 28, 2023
Merged

[netatmo] Enable home being both energy and security #16026

merged 1 commit into from Dec 28, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Dec 9, 2023 •
edited by jlaur

Resolves #15928

@clinique
Enable home being both energy and security
cf1aa70 
Signed-off-by: clinique <gael@lhopital.org>
lolodomo
lolodomo approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

lolodomo commented Dec 9, 2023

@clinique : is it already tested ?

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Dec 9, 2023
@clinique
Copy link
Contributor Author

clinique commented Dec 9, 2023

@clinique : is it already tested ?

No, submitted in the issue for testing and feed back. Can not be merged

@lolodomo lolodomo added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Dec 10, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Dec 14, 2023 •
edited

Do we delay the merge after OH4.1 is released ?
Or are you enough confident with your change @clinique ?

@clinique
Copy link
Contributor Author

Do we delay the merge after OH4.1 is released ?
Or are you enough confident with your change @clinique ?

We should wait, I did not had time to dig a weird thing

@clinique clinique removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Dec 27, 2023
@clinique
Copy link
Contributor Author

@lolodomo : this one is ready to go.

@lolodomo lolodomo merged commit 13a0616 into openhab:main Dec 28, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Dec 28, 2023
@lolodomo
Copy link
Contributor

@clinique : is the bug enough serious that we should back port your fix to 4.1.x ?

@clinique
Copy link
Contributor Author

This is a rare case when both energy and security are hosted by the same Netatmo Home. I never succeeded doing this on my own configuration. For peace of mind, I think it would be worth backporting it or else we'll never think to it again.

@VeronikaWehrle
Copy link

Hi, a downport to 4.1.x would be highly appreciated. We have the same issue ;-)
Thanks for your great work!

@mdillmann
Copy link

Hi,
was the fix backported to 4.1.x ?

I just updated my production OH from 3.4 to 4.1.1 and hoped it would remedy my room issue, but it is still there.

If it was, I'll do some investigation why it still doesn't work in my setup.

jlaur pushed a commit to jlaur/openhab-addons that referenced this pull request Mar 23, 2024
@clinique @jlaur
Enable home being both energy and security (openhab#16026)
346bf00 
Signed-off-by: clinique <gael@lhopital.org>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@clinique @austvik
Enable home being both energy and security (openhab#16026)
3acf669 
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@clinique clinique deleted the netatmo_15928 branch March 30, 2024 09:58
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[netatmo] Things linked to the bridge "netatmo:home" doesn't work after OH 4.x
5 participants
@clinique @lolodomo @VeronikaWehrle @mdillmann @openhab-bot