Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.generic] Expose more advanced rollshutter config options #16051

Merged
merged 1 commit into from Jan 14, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 11, 2023

The underlying support is used by the Home Assistant binding, but may be useful for others.

That are used by the Home Assistant binding, but may be useful
for others.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/help-with-mqtt/151535/11

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Dec 15, 2023
Copy link
Contributor

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccutrer
Copy link
Contributor Author

ccutrer commented Jan 9, 2024

ping @jlaur/@lolodomo

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 78669da into openhab:main Jan 14, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jan 14, 2024
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
…ab#16051)

That are used by the Home Assistant binding, but may be useful
for others.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…ab#16051)

That are used by the Home Assistant binding, but may be useful
for others.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@ccutrer ccutrer deleted the mqtt-generic-rollershutter-options branch April 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants