[mqtt.homeassistant] Improve support for Lock component #16052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ccutrer
commented
Dec 11, 2023
ccutrer
commented
- handle state and command payloads differing (as they do by default)
- expose full state possibilities and OPEN command by adding a TextValue channel
* handle state and command payloads differing (as they do by default) * expose full state possibilities and OPEN command by adding a TextValue channel Signed-off-by: Cody Cutrer <cody@cutrer.us>
lolodomo
added
the
enhancement
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
kaikreuzer
requested changes
Jan 1, 2024
...ab.binding.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/values/TextValue.java
Outdated
Show resolved
Hide resolved
...ab.binding.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/values/TextValue.java
Outdated
Show resolved
Hide resolved
...ab.binding.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/values/TextValue.java
Outdated
Show resolved
Hide resolved
...ab.binding.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/values/TextValue.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
commented
Jan 2, 2024
...eassistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Lock.java
Show resolved
Hide resolved
Cybso
pushed a commit
to Cybso/openhab-addons
that referenced
this pull request
Jan 5, 2024
* [mqtt.homeassistant] Improve support for Lock component * handle state and command payloads differing (as they do by default) * expose full state possibilities and OPEN command by adding a TextValue channel * Recognize intermediate lock states as unlocked on the switch channel Signed-off-by: Cody Cutrer <cody@cutrer.us>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [mqtt.homeassistant] Improve support for Lock component * handle state and command payloads differing (as they do by default) * expose full state possibilities and OPEN command by adding a TextValue channel * Recognize intermediate lock states as unlocked on the switch channel Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.