Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nuvo] Display album art from MPS4 #16068

Merged
merged 8 commits into from Feb 15, 2024
Merged

Conversation

mlobstein
Copy link
Contributor

@mlobstein mlobstein commented Dec 16, 2023

This change implements retrieval of album art for MPS4 sources. The album art for the currently playing local media or stream that displays in the Nuvo/Mirage app or web UI will now be displayed in the existing Image channel.

I have been running the binding on my system with this code for almost a year and it works well.

Test build: https://github.com/mlobstein/openhab-addons/releases/download/v4.1.0beta/org.openhab.binding.nuvo-4.1.0-SNAPSHOT.jar

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the enhancement An enhancement or new feature for an existing add-on label Dec 16, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@lolodomo
Copy link
Contributor

lolodomo commented Feb 4, 2024

Code looks good to me.
Please fix the conflict so that I can merge.

@lsiepel lsiepel requested a review from a team February 4, 2024 22:06
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
Copy link
Contributor Author

Code looks good to me. Please fix the conflict so that I can merge.

Sorry I missed the notification. The merge conflicts have been fixed.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 945dd13 into openhab:main Feb 15, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Feb 15, 2024
@mlobstein mlobstein deleted the nuvo_mps4art branch February 16, 2024 05:30
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* Display album art from MPS4
* Display album art from MPS4

---------

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants