[knx] Allow receiving DPT 235.001 #16094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerfriedrich
added
the
enhancement
holgerfriedrich
force-pushed
the
pr-knx-235
branch
2 times, most recently
from
7f5a72b
to
c6f9e36
Compare
|
@dsacchet FYI, PR is ready for testing. Could you give it a try? I don't have the hardware, I just sent some packets with ETS. |
holgerfriedrich
force-pushed
the
pr-knx-235
branch
2 times, most recently
from
0ab4f5f
to
5445917
Compare
Composed type not yet supported by Calimero, thus only receiving data is implemented. Configure DPT 235.001 to receive ActiveEnergy. Configure DPT 235.61001 to receive Tariff information. Fixes openhab#15159 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
force-pushed
the
pr-knx-235
branch
from
5445917
to
14efeba
Compare
J-N-K
reviewed
Jan 4, 2024
|
Code lgtm, before a merge, i think it would be good to have a comment from @kaikreuzer or @J-N-K about this review comment: #16094 (comment) While tests are supplied, did you also have test results from @dsacchet ? |
|
Thanks! |
J-N-K
approved these changes
Jan 22, 2024
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 27, 2024
* [knx] Allow receiving DPT 235.001 Composed type not yet supported by Calimero, thus only receiving data is implemented. Configure DPT 235.001 to receive ActiveEnergy. Configure DPT 235.61001 to receive Tariff information. Fixes openhab#15159 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
ulbi
pushed a commit
to ulbi/openhab-addons
that referenced
this pull request
Jan 28, 2024
* [knx] Allow receiving DPT 235.001 Composed type not yet supported by Calimero, thus only receiving data is implemented. Configure DPT 235.001 to receive ActiveEnergy. Configure DPT 235.61001 to receive Tariff information. Fixes openhab#15159 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: René Ulbricht <rene_ulbricht@outlook.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [knx] Allow receiving DPT 235.001 Composed type not yet supported by Calimero, thus only receiving data is implemented. Configure DPT 235.001 to receive ActiveEnergy. Configure DPT 235.61001 to receive Tariff information. Fixes openhab#15159 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composed type not yet supported by Calimero, thus only receiving data is implemented.
Configure DPT 235.001 to receive ActiveEnergy.
Configure DPT 235.61001 to receive Tariff information.
Fixes #15159