Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.espmilighthub] Fix upgrade instructions #16127

Merged
merged 1 commit into from Dec 27, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 27, 2023

since #13801, it's not been possible to add new milight things, because the thing XML already has the new channel types, but not the thingTypeVersion property set, so it would try to apply the update instructions and error about duplicate channels

since openhab#13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 27, 2023

@lolodomo @jlaur: this should also be applied to the 4.1.x branch, since it's a regression in 4.1.0

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit e81550f into openhab:main Dec 27, 2023
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Dec 27, 2023
jlaur pushed a commit that referenced this pull request Dec 27, 2023
since #13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@jlaur jlaur added patch A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on labels Dec 27, 2023
@jlaur jlaur changed the title [mqtt.espmilighthub] fix upgrade instructions [mqtt.espmilighthub] Fix upgrade instructions Dec 27, 2023
@ccutrer ccutrer deleted the mqtt-espmilightub-thing-type-version branch December 28, 2023 14:51
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
since openhab#13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants