[sonos] Prevent logging unsupported device #16141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
commented
Dec 29, 2023
| @@ -83,7 +83,8 @@ public Set<ThingTypeUID> getSupportedThingTypeUIDs() { | |||
| String id = SonosXMLParser | |||
| .buildThingTypeIdFromModelName(device.getDetails().getModelDetails().getModelName()); | |||
| String udn = device.getIdentity().getUdn().getIdentifierString(); | |||
| if (!id.isEmpty() && !"Sub".equalsIgnoreCase(id) && !udn.isEmpty()) { | |||
| if (!id.isEmpty() && !SonosBindingConstants.UNSUPPORTED_KNOWN_IDS.contains(id.toLowerCase()) | |||
There was a problem hiding this comment.
@lolodomo i would prefer equals above contains, but in that case the constant needs all exact modelnames. Do you know them or have a source where i can find them?
There was a problem hiding this comment.
No, we discover them each time Sonos introduces a new model...
dbadia
pushed a commit
to dbadia/openhab2-addons
that referenced
this pull request
Dec 31, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Cybso
pushed a commit
to Cybso/openhab-addons
that referenced
this pull request
Jan 5, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
changed the title
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices like subs are more or less a transparant slave and are not added to openHAB as Thing. As the amount of devices slowly grows a more future proof check is needed to prevent unwanted logging.
Fixes: #16125