Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wled] Fix Playlist and Preset detection when missing bri values #16146

Merged
merged 1 commit into from Dec 31, 2023

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Dec 30, 2023

Presets can have the bri value missing and the binding was using this to detect playlist objects from presets. This PR fixes this and should be backwards and forwards compatible with different firmwares. Reported on the forum here:

https://community.openhab.org/t/wled-0-14-doesnt-fetch-preset/152313

This pull request is available under the following links if anyone wants to test:
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/

Just the needed jar.
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.wled/4.2.0-SNAPSHOT/org.openhab.binding.wled-4.2.0-SNAPSHOT.jar

Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Dec 30, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/wled-0-14-doesnt-fetch-preset/152313/7

@nodiaque
Copy link

Just to add to the discussion. The Br value can be missing in any firmware version. When you save the preset you select if you want or not to save these value. I have some preset that I explicitly didn't put these value or other value in it (for other effect for instance).

@Skinah Skinah changed the title [wled] Fix Playlist vs Preset detection for newer firmwares [wled] Fix Playlist and Preset detection when missing bri values Dec 30, 2023
@Skinah
Copy link
Contributor Author

Skinah commented Dec 30, 2023

Thanks, have updated the info as it goes into the change log. @nodiaque Any chance you can test if this fixes all issues on your system?

@lolodomo
Copy link
Contributor

@Skinah : shall we wait for a positive test or is it fine for you to merge it immediately ?

@Skinah
Copy link
Contributor Author

Skinah commented Dec 31, 2023

Merge please as it works for me and is an obvious bug with hind sight.

@lolodomo lolodomo merged commit 706ae58 into openhab:main Dec 31, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Dec 31, 2023
dbadia pushed a commit to dbadia/openhab2-addons that referenced this pull request Dec 31, 2023
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@nodiaque
Copy link

Sorry I'm outside for the next week so I can't test

Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
Signed-off-by: Matthew Skinner <matt@pcmus.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants