New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wled] Fix Playlist and Preset detection when missing bri values #16146
Conversation
Signed-off-by: Matthew Skinner <matt@pcmus.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/wled-0-14-doesnt-fetch-preset/152313/7 |
Just to add to the discussion. The Br value can be missing in any firmware version. When you save the preset you select if you want or not to save these value. I have some preset that I explicitly didn't put these value or other value in it (for other effect for instance). |
Thanks, have updated the info as it goes into the change log. @nodiaque Any chance you can test if this fixes all issues on your system? |
@Skinah : shall we wait for a positive test or is it fine for you to merge it immediately ? |
Merge please as it works for me and is an obvious bug with hind sight. |
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sorry I'm outside for the next week so I can't test |
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Presets can have the
bri
value missing and the binding was using this to detect playlist objects from presets. This PR fixes this and should be backwards and forwards compatible with different firmwares. Reported on the forum here:https://community.openhab.org/t/wled-0-14-doesnt-fetch-preset/152313
This pull request is available under the following links if anyone wants to test:
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/
Just the needed jar.
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.wled/4.2.0-SNAPSHOT/org.openhab.binding.wled-4.2.0-SNAPSHOT.jar