Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Fix WebSocketServerFactory ClassNotFoundException #16150

Merged
merged 1 commit into from Dec 31, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 30, 2023

Adds a package import so the class can be found by the class loader.

Fixes #16118

Adds a package import so the class can be found by the class loader.

Fixes openhab#16118

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Dec 30, 2023
@wborn wborn requested a review from a team December 30, 2023 17:28
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/3596

@lolodomo
Copy link
Contributor

@wborn : does it require a test to confirm that the issue is resolved or are you enough sure that I can immediately merge ?

@wborn
Copy link
Member Author

wborn commented Dec 31, 2023

I don't have any Shelly devices myself but I was able to reproduce the exception by opening a WebSocket to the Servlet. Then I saw the exception and it was gone with this fix. So I hope it is fully functional again now!

@lolodomo lolodomo merged commit 607c647 into openhab:main Dec 31, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Dec 31, 2023
@wborn wborn deleted the shelly-cnfe branch December 31, 2023 10:49
@jlaur
Copy link
Contributor

jlaur commented Dec 31, 2023

@wborn - since this was reported as a regression in 4.1, will you cherry-pick to 4.1.x?

@wborn
Copy link
Member Author

wborn commented Dec 31, 2023

Yes that would be nice, but I don't think I'll be able to do that until next year. 😉

@jlaur
Copy link
Contributor

jlaur commented Dec 31, 2023

Yes that would be nice, but I don't think I'll be able to do that until next year. 😉

No problem. If you agree, I'm in front of a computer right now and can do it. 🙂

@wborn
Copy link
Member Author

wborn commented Dec 31, 2023

If you can do it that would be nice 👍

jlaur pushed a commit that referenced this pull request Dec 31, 2023
Adds a package import so the class can be found by the class loader.

Fixes #16118

Signed-off-by: Wouter Born <github@maindrain.net>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Dec 31, 2023
dbadia pushed a commit to dbadia/openhab2-addons that referenced this pull request Dec 31, 2023
…6150)

Adds a package import so the class can be found by the class loader.

Fixes openhab#16118

Signed-off-by: Wouter Born <github@maindrain.net>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh-4-1-0-rc1-error-reporting-at-startup-coming-from-oh3-x/152662/2

Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
…6150)

Adds a package import so the class can be found by the class loader.

Fixes openhab#16118

Signed-off-by: Wouter Born <github@maindrain.net>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…6150)

Adds a package import so the class can be found by the class loader.

Fixes openhab#16118

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Shelly] Websocket not working since openHAB 4.1.0.M4
4 participants