New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Fix WebSocketServerFactory ClassNotFoundException #16150
Conversation
Adds a package import so the class can be found by the class loader. Fixes openhab#16118 Signed-off-by: Wouter Born <github@maindrain.net>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
@wborn : does it require a test to confirm that the issue is resolved or are you enough sure that I can immediately merge ? |
I don't have any Shelly devices myself but I was able to reproduce the exception by opening a WebSocket to the Servlet. Then I saw the exception and it was gone with this fix. So I hope it is fully functional again now! |
@wborn - since this was reported as a regression in 4.1, will you cherry-pick to 4.1.x? |
Yes that would be nice, but I don't think I'll be able to do that until next year. 😉 |
No problem. If you agree, I'm in front of a computer right now and can do it. 🙂 |
If you can do it that would be nice 👍 |
Adds a package import so the class can be found by the class loader. Fixes #16118 Signed-off-by: Wouter Born <github@maindrain.net>
…6150) Adds a package import so the class can be found by the class loader. Fixes openhab#16118 Signed-off-by: Wouter Born <github@maindrain.net>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh-4-1-0-rc1-error-reporting-at-startup-coming-from-oh3-x/152662/2 |
…6150) Adds a package import so the class can be found by the class loader. Fixes openhab#16118 Signed-off-by: Wouter Born <github@maindrain.net>
…6150) Adds a package import so the class can be found by the class loader. Fixes openhab#16118 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Adds a package import so the class can be found by the class loader.
Fixes #16118