Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ojelectronics] Adjust setpoint command handling #16159

Merged
merged 1 commit into from Jan 15, 2024

Conversation

EvilPingu
Copy link
Contributor

@EvilPingu EvilPingu commented Dec 31, 2023

Description

Since version OH4.1 (maybe OH4) there are some problems with setting temperatur values. The reasons seems to be that sometimes the command is not a QuantityType<?> but a Number.

This PR fixes #16158

@EvilPingu EvilPingu force-pushed the Feature/CommandHandler branch 2 times, most recently from 286302b to f88c8c5 Compare January 14, 2024 13:53
Signed-off-by: Christian Kittel <ckittel@gmx.de>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo changed the title [ojelectronics] Adjust command handling [ojelectronics] Adjust setpoint command handling Jan 15, 2024
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jan 15, 2024
@lolodomo lolodomo added this to the 4.2 milestone Jan 15, 2024
@lolodomo lolodomo merged commit 77e935a into openhab:main Jan 15, 2024
3 checks passed
@EvilPingu
Copy link
Contributor Author

@lolodomo Thanks for your support

@EvilPingu EvilPingu deleted the Feature/CommandHandler branch January 15, 2024 18:37
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
Signed-off-by: Christian Kittel <ckittel@gmx.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Christian Kittel <ckittel@gmx.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ojelectronics] Error "Unable to set value 25" if setting temperatur value
2 participants