[smartmeter] Prevent NumberFormatException #16183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsiepel
commented
Jan 2, 2024
lsiepel
commented
- Fixes [Smartmeter] Negation based on channel value produces NumberFormatException #11029 by handling the way string values are converted to long.
- Adds test to prevent regression
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
...r/src/main/java/org/openhab/binding/smartmeter/internal/conformity/negate/NegateHandler.java
Outdated
Show resolved
Hide resolved
msteigenberger
approved these changes
Jan 10, 2024
|
@lsiepel thanks for fixing this. Changes looks good to me! |
lolodomo
reviewed
Jan 13, 2024
...r/src/main/java/org/openhab/binding/smartmeter/internal/conformity/negate/NegateHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
ulbi
pushed a commit
to ulbi/openhab-addons
that referenced
this pull request
Jan 28, 2024
* Fix NumberFormatException * Fix logger comment --------- Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: René Ulbricht <rene_ulbricht@outlook.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Fix NumberFormatException * Fix logger comment --------- Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.