Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inmemory] Add filterCritera ordering #16185

Merged
merged 1 commit into from Jan 2, 2024
Merged

[inmemory] Add filterCritera ordering #16185

merged 1 commit into from Jan 2, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 2, 2024

Implements #16175

@J-N-K
[inmemory] Add filterCritera ordering
0802692 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Jan 2, 2024
@jlaur jlaur linked an issue Jan 2, 2024 that may be closed by this pull request
[inmemory] Query does not consider FilterCriteria.getOrdering() #16175
Closed
jlaur
jlaur approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM, and I have tested it successfully as well.

@jlaur jlaur merged commit 8a0361f into openhab:main Jan 2, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Jan 2, 2024
@J-N-K J-N-K deleted the inmemory branch January 2, 2024 19:26
@jlaur
Copy link
Contributor

jlaur commented Jan 2, 2024

@J-N-K - I can see that you don't consider it as a bugfix, but rather an enhancement. I guess it's a matter of definition.

The reason I created the issue as a bug is that HistoricItem historicState(Item item, ZonedDateTime timestamp, String serviceId) in PersistenceExtensions didn't work as expected because the ordering criteria was not considered.

My question is if you'd agree it can be considered as a bug and therefore cherry-picked into 4.1.x? It looks like the risk is very low, and probably it's not even in wide use yet.

@J-N-K
Copy link
Member Author

J-N-K commented Jan 2, 2024

Sure. If you want you can also change the label to bug.

jlaur pushed a commit that referenced this pull request Jan 2, 2024
@J-N-K @jlaur
[inmemory] Add filterCritera ordering (#16185)
d434fc5 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch and removed enhancement An enhancement or new feature for an existing add-on labels Jan 2, 2024
Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
@J-N-K @Cybso
[inmemory] Add filterCritera ordering (openhab#16185)
7f56e8a 
Signed-off-by: Jan N. Klug <github@klug.nrw>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@J-N-K @austvik
[inmemory] Add filterCritera ordering (openhab#16185)
3bbdf2e 
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[inmemory] Query does not consider FilterCriteria.getOrdering()
2 participants
@J-N-K @jlaur