[chromecast] Update protobuf from 2.6.0 to protobuf-javalite 3.25.1 #16186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from vitalidze/chromecast-java-api-v2 to de.sfuhrm/chromecast-java-api-v2. This fork updates protobuf-java from 2.6.0 to protobuf-javalite 3.25.1. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
added
awaiting feedback
work in progress
Yes I still had this on my todo list 😉, I'll give it a try soon. 👍 |
|
It works very well for me so far. 👍 |
wborn
reviewed
Jan 3, 2024
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
removed
awaiting feedback
work in progress
|
@wborn thank you for testing it. 👍 |
Cybso
pushed a commit
to Cybso/openhab-addons
that referenced
this pull request
Jan 5, 2024
…penhab#16186) Switch from vitalidze/chromecast-java-api-v2 to de.sfuhrm/chromecast-java-api-v2. This fork updates protobuf-java from 2.6.0 to protobuf-javalite 3.25.1. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…penhab#16186) Switch from vitalidze/chromecast-java-api-v2 to de.sfuhrm/chromecast-java-api-v2. This fork updates protobuf-java from 2.6.0 to protobuf-javalite 3.25.1. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf library 2.6.0 has known issues and causes security warnings.
Try to update protobuf to a more recent release (which does not issue update warnings).
Not sure if this works.
@wborn You offered to do some testing on the forum, so maybe you could give it a try.