Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[energidataservice] Remove obsoleted advanced channel hourly-prices #16190

Merged
merged 1 commit into from Jan 13, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 2, 2024

With the introduction of openhab/openhab-core#3597 and #15063 in openHAB 4.1, the advanced channel hourly-prices is now fully obsoleted.

It was already possible to use binding-specific Thing actions for importing future prices into rules, but since 4.1.1 it's also possible to access future prices through in-memory persistence, i.e. persisted time series.

Therefore, the binding can be simplified by removing this channel.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 2, 2024
@jlaur jlaur requested a review from a team January 4, 2024 21:54
@jlaur jlaur changed the title [energidataservice] Remove obsoleted advanced channel hourly-prices [energidataservice] Remove obsoleted advanced channel hourly-prices Jan 4, 2024
@jlaur jlaur force-pushed the energidataservice-hourly-prices branch 2 times, most recently from ac8e6e2 to 2a72e1c Compare January 7, 2024 11:29
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the energidataservice-hourly-prices branch from 2a72e1c to 9cfc5e5 Compare January 9, 2024 22:52
Comment on lines +352 to +368
### Persistence Configuration

```java
Strategies {
default = everyChange
}

Items {
SpotPrice,
GridTariff,
SystemTariff,
TransmissionGridTariff,
ElectricityTax: strategy = forecast
}
```

In case persistence is only needed for charts and/or accessing prices from rules, [InMemory Persistence](https://www.openhab.org/addons/persistence/inmemory/) can be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thank for providing this example, this is something missing in " InMemory Persistence" service.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 9afbe0b into openhab:main Jan 13, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jan 13, 2024
@jlaur jlaur deleted the energidataservice-hourly-prices branch January 13, 2024 16:38
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/bringing-electricity-information-from-eloverblik-dk-and-energidataservice-dk-into-openhab/143470/94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants