[homematic] Add Authentication #16196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilPingu
added
the
enhancement
Signed-off-by: Christian Kittel <ckittel@gmx.de>
EvilPingu
force-pushed
the
Feature/8625_HM_Auth
branch
from
f3f9fa5
to
e4e0fa2
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/authentication-for-api-access-to-ccu/152635/1 |
lsiepel
requested changes
Jan 3, 2024
...matic/src/main/java/org/openhab/binding/homematic/internal/common/AuthenticationHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.homematic/src/main/resources/OH-INF/i18n/homematic_de.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.homematic/src/main/resources/OH-INF/thing/bridge.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.homematic/src/main/resources/OH-INF/thing/bridge.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.homematic/src/main/resources/OH-INF/thing/bridge.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.homematic/src/main/resources/OH-INF/thing/bridge.xml
Outdated
Show resolved
Hide resolved
...matic/src/main/java/org/openhab/binding/homematic/internal/common/AuthenticationHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christian Kittel <ckittel@gmx.de>
Thanks for your remarks. Changed the error handling a little bit |
EvilPingu
force-pushed
the
Feature/8625_HM_Auth
branch
2 times, most recently
from
5314c18
to
bdd75ac
Compare
lsiepel
requested changes
Jan 21, 2024
...matic/src/main/java/org/openhab/binding/homematic/internal/common/AuthenticationHandler.java
Outdated
Show resolved
Hide resolved
...tic/src/main/java/org/openhab/binding/homematic/internal/handler/HomematicBridgeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.homematic/src/main/resources/OH-INF/i18n/homematic.properties
Outdated
Show resolved
Hide resolved
EvilPingu
force-pushed
the
Feature/8625_HM_Auth
branch
2 times, most recently
from
324cdc3
to
6af7885
Compare
…eption Signed-off-by: Christian Kittel <ckittel@gmx.de>
EvilPingu
force-pushed
the
Feature/8625_HM_Auth
branch
from
6af7885
to
b3ef54d
Compare
all done |
lsiepel
approved these changes
Feb 10, 2024
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Add Authentication --------- Signed-off-by: Christian Kittel <ckittel@gmx.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enable authorization (resolves #8625 ) when accessing Homematic Server (like CCU). I've added three new binding configuration values to enable this. Now it's possible to disable unauthorized accesses to the CCU. I added some documentation which is relevant for testing.
Testing
I tested the new feature with raspberrymatic and OH running in a K8s environment. I thinks it's necessary to test it with other settings.