Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[systeminfo] Bump OSHI to 6.4.8 #16197

Merged
merged 1 commit into from Jan 4, 2024
Merged

[systeminfo] Bump OSHI to 6.4.8 #16197

merged 1 commit into from Jan 4, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 3, 2024

This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0

This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Jan 3, 2024
@J-N-K J-N-K requested a review from mherwege as a code owner January 3, 2024 17:42
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-1-release-discussion/152252/115

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@J-N-K
Copy link
Member Author

J-N-K commented Jan 3, 2024

Even if it was not the OP's issue: merging this cleans up out dependencies.

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn merged commit b8c3c3d into openhab:main Jan 4, 2024
3 checks passed
@J-N-K J-N-K deleted the systeminfo branch January 4, 2024 08:24
Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0

Signed-off-by: Jan N. Klug <github@klug.nrw>
@mhilbush
Copy link
Contributor

@J-N-K Does someone (@kaikreuzer) need to upload this new version to Artifactory. In snapshot build 3845 the installer is complaining that mvn:com.github.oshi/oshi-core/6.4.8 can't be downloaded.

@J-N-K
Copy link
Member Author

J-N-K commented Jan 18, 2024

it's available on maven central, I thought it was automatically transferred to the artifactory during a build

@mhilbush
Copy link
Contributor

I just looked on https://openhab.jfrog.io/ and 6.2.2 is the latest version there. Am I looking in the right place?

@J-N-K
Copy link
Member Author

J-N-K commented Jan 19, 2024

@kaikreuzer Do you have an idea what is missing here? We have upgraded the dependency the same way we did in the past and never faced an issue with artifacts from maven central.

@mherwege
Copy link
Contributor

Could it be (wild guess) it kept the wrong version because the integration test still has version 6.2.2 in its pom.xml? That's fixed with #16012.

@kaikreuzer
Copy link
Member

I thought it was automatically transferred to the artifactory during a build

@J-N-K No, unfortunately, this is still done manually. I just did so for version 6.4.8 of that library.

@J-N-K
Copy link
Member Author

J-N-K commented Jan 20, 2024

Interesting. So you manually upload when we upgrade any dependency? Or just some special ones?

@kaikreuzer
Copy link
Member

Any dependency of an add-on that is not embedded into the jar. All core dependencies are packaged into the runtime, so for those there is no need to upload them.

@J-N-K
Copy link
Member Author

J-N-K commented Jan 20, 2024

Thanks! I'll keep that in mind.

@lsiepel lsiepel added this to the 4.2 milestone Feb 17, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants