New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[systeminfo] Bump OSHI to 6.4.8 #16197
Conversation
This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0 Signed-off-by: Jan N. Klug <github@klug.nrw>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-1-release-discussion/152252/115 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Even if it was not the OP's issue: merging this cleans up out dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0 Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K Does someone (@kaikreuzer) need to upload this new version to Artifactory. In snapshot build 3845 the installer is complaining that |
it's available on maven central, I thought it was automatically transferred to the artifactory during a build |
I just looked on https://openhab.jfrog.io/ and 6.2.2 is the latest version there. Am I looking in the right place? |
@kaikreuzer Do you have an idea what is missing here? We have upgraded the dependency the same way we did in the past and never faced an issue with artifacts from maven central. |
Could it be (wild guess) it kept the wrong version because the integration test still has version 6.2.2 in its pom.xml? That's fixed with #16012. |
@J-N-K No, unfortunately, this is still done manually. I just did so for version 6.4.8 of that library. |
Interesting. So you manually upload when we upgrade any dependency? Or just some special ones? |
Any dependency of an add-on that is not embedded into the jar. All core dependencies are packaged into the runtime, so for those there is no need to upload them. |
Thanks! I'll keep that in mind. |
This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0 Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
This is the latest OSHI version that is compatible with the Karaf provided JNA 5.13.0