[dolbycp] Initial Contribution

[Cybso]

Added new binding cp750 for Dolby Digital Cinema Processor CP750

I have written a new binding to communicate with a CP750, a common sound processor used in cinemas which can be controlled using a TCP socket.

The binding is based on the java library https://github.com/Cybso/cp750-java/ that I wrote earlier.

The release file is available at https://github.com/Cybso/openhab-addons/releases/tag/release-0.1

[lsiepel]

Thanks for your contribution. Now i want this device too :-/
Left some comments to check, first pass, mainly looked at documentation I don't see a linked issues or community, so not sure if it was discussed; is cp750 the right name for this binding? On the website i also see that an CP850 exists, and maybe more will follow. If possible a more generic /brand / family / protocol level would be great so that in future it can support multiple devices, does that make sense?

[Cybso]

Thank you for your review. I will apply the changes, but I'm busy the next two days, so I will have to wait until Monday or Tuesday.

I don't see a linked issues or community, so not sure if it was discussed

I saw no reason to discuss this because there wasn't a binding to speak with this device, and I needed one :-)

is cp750 the right name for this binding?

I have checked other sound processors from Dolby like CP650 or CP950. The CP650 does not seem to speak any TCP protocol at all, and the CP950 has a similar protocol, but only allows to set fader value and mute, no input channel. I also wanted to avoid the brand name "dolby".

[lsiepel]

Some more comments, not looked at the actual code yet.

[lsiepel]

There are some open comments from a previous review, reviewed all files except DolbyCPHandler.java. That needs some further checks i'll do in the coming days.

[Cybso]

There are some open comments from a previous review, reviewed all files except DolbyCPHandler.java. That needs some further checks i'll do in the coming days.

Thank you very much for your comments.

Unless I have overlooked something, I have asked for feedback on the outstanding points. Especially with the textual Things definition I would need some support, because I have seen contradictory spellings in the README files of the existing bindings (see pending note on README.md in https://github.com/openhab/openhab-addons/pull/16216/files/888c0195f20902151c01c4526907534782be656f ).

[lsiepel]

There are some open comments from a previous review, reviewed all files except DolbyCPHandler.java. That needs some further checks i'll do in the coming days.

Thank you very much for your comments.

Unless I have overlooked something, I have asked for feedback on the outstanding points. Especially with the textual Things definition I would need some support, because I have seen contradictory spellings in the README files of the existing bindings (see pending note on README.md in https://github.com/openhab/openhab-addons/pull/16216/files/888c0195f20902151c01c4526907534782be656f ).

Strange:
os-version comment: #16216 (comment)
things example comment: #16216 (comment)

One aditional comment while looking at it: The dependency for de.cybso.cp750 needs to be listed in the notice file

[Cybso]

I have implemented the trivial changes. The suggestions to DolbyCPHandler are a bit more complex, I have to think about that (and test them, of course).

Unless I have overlooked something, I have asked for feedback on the outstanding points. Especially with the textual Things definition I would need some support, because I have seen contradictory spellings in the README files of the existing bindings (see pending note on README.md in https://github.com/openhab/openhab-addons/pull/16216/files/888c0195f20902151c01c4526907534782be656f ).

Strange: os-version comment: #16216 (comment) things example comment: #16216 (comment)

I somehow have the feeling that we're talking at cross purposes. What do you mean by "strange" in this context? These are the pending questions I have referred to.

[lsiepel]

mehow have the feeling that we're talking at cross purposes. What do you mean by "strange" in this context? These are the pending questions I have referred to.

Take your time, no need to rush.

We might cross-talk there :-) I meant strange, as in I don't see your reply or change. For example, this one is left open:
#16216 (comment)

[Cybso]

We might cross-talk there :-) I meant strange, as in I don't see your reply or change. For example, this one is left open: #16216 (comment)

I have commented to this one:

I wanted to show this version string on the control panel when the device comes online. Is this possible with thing properties?

But the comment shows a "pending" flag. How can I "commit" this comment? The button "Resolve Conversionen" marks the issue as resolved, doesn't it?

Edit: Finally found it. Thanks to https://github.com/orgs/community/discussions/10369

[lsiepel]

I wanted to show this version string on the control panel when the device comes online. Is this possible with thing properties?

Really think this os-version should be modelled as Thing property. It will then be shown in the Thing details page.

[Cybso]

For personal reasons, I unfortunately had to leave this a little longer than I wanted.

I have now restructured the code and converted "osversion" into a property.

As far as I can see, the last open question is the example configuration, right?

[lsiepel]

Very minor last comments before merger

[Cybso]

Thank you very much! Please wait a moment before merge. I want to do a full test in my production environment but I have to wait until tomorrow morning before I can do a test in our cinema :-)

[lsiepel]

LGTM

[Cybso]

I have done a full check in our theater using the new version and everything works fine.

Thank you very much for your help, @lsiepel!