Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sbus] Initial Contribution #16226

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[sbus] Initial Contribution #16226

wants to merge 4 commits into from

Conversation

cipianpascu
Copy link

@cipianpascu cipianpascu commented Jan 7, 2024 •
edited

This is the first attempt to implement the S-Bus G4 transport protocol.
The code is derived from the Modbus transport protocol and has the following two additions:

  1. TCP protocol is replaced with UDP protocol
  2. All the protocol queries have a subnetId byte in addition to the deviceId and functionId.
    Please look at what I did, and let me know about the additional changes/fixes required for this new transport protocol/binding.

@cipianpascu cipianpascu requested review from GiviMAD and a team as code owners January 7, 2024 09:49
S-Bus binding protocol. Derived from Modbus protocol
2ee968f 
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-transport-protocol-s-bus-g4/152769/1

@lsiepel lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Apr 7, 2024
@lsiepel lsiepel changed the title S-Bus binding protocol. Derived from Modbus protocol [sbus] Initial Contribution Apr 7, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Apr 7, 2024

Maybe this should be a subbinding of modbus or an addition to the current binding? Don't know it that makes sense, i'm no modbus expert.
Anyway, it needs some work regarding documentaiton, relation with modbus and the builds fail. I would also suggest to add a testable jar file. Would be nice to have a community or marketplace thread with users that tried this binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiviMAD GiviMAD Awaiting requested review from GiviMAD GiviMAD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting feedback new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cipianpascu @openhab-bot @lsiepel