New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[influxdb] Fix exception handling for InfluxDB 1.x #16234
Merged
lolodomo
merged 1 commit into
openhab:main
from
jlaur:16233-influxdb-exception-handling
Jan 13, 2024
Merged
[influxdb] Fix exception handling for InfluxDB 1.x #16234
lolodomo
merged 1 commit into
openhab:main
from
jlaur:16233-influxdb-exception-handling
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
force-pushed
the
16233-influxdb-exception-handling
branch
from
January 7, 2024 14:30
3358b2f
to
5582b6b
Compare
Fixes openhab#16233 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
My previous analysis was wrong, this time it should work better. |
jlaur
force-pushed
the
16233-influxdb-exception-handling
branch
from
January 7, 2024 14:52
5582b6b
to
14ab2ec
Compare
jlaur
added
the
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
label
Jan 7, 2024
jlaur
removed
the
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
label
Jan 12, 2024
lolodomo
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
AntonJansen
pushed a commit
to AntonJansen/openhab-addons
that referenced
this pull request
Jan 13, 2024
Fixes openhab#16233 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
added a commit
that referenced
this pull request
Jan 14, 2024
Fixes #16233 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 27, 2024
Fixes openhab#16233 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Fixes openhab#16233 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16233