Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[influxdb] Fix exception handling for InfluxDB 1.x #16234

Merged
merged 1 commit into from Jan 13, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 7, 2024

Fixes #16233

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jan 7, 2024
@jlaur jlaur requested a review from lujop as a code owner January 7, 2024 14:23
@jlaur jlaur marked this pull request as draft January 7, 2024 14:24
@jlaur jlaur force-pushed the 16233-influxdb-exception-handling branch from 3358b2f to 5582b6b Compare January 7, 2024 14:30
@jlaur jlaur closed this Jan 7, 2024
Fixes openhab#16233

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Copy link
Contributor Author

jlaur commented Jan 7, 2024

My previous analysis was wrong, this time it should work better.

@jlaur jlaur reopened this Jan 7, 2024
@jlaur jlaur force-pushed the 16233-influxdb-exception-handling branch from 5582b6b to 14ab2ec Compare January 7, 2024 14:52
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jan 7, 2024
@jlaur jlaur marked this pull request as ready for review January 12, 2024 14:20
@jlaur jlaur removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jan 12, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 3f4aac9 into openhab:main Jan 13, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jan 13, 2024
@jlaur jlaur deleted the 16233-influxdb-exception-handling branch January 13, 2024 16:37
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jan 13, 2024
AntonJansen pushed a commit to AntonJansen/openhab-addons that referenced this pull request Jan 13, 2024
Fixes openhab#16233

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur added a commit that referenced this pull request Jan 14, 2024
Fixes #16233

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
Fixes openhab#16233

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Fixes openhab#16233

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[influxdb] persistence service does not recover from connection loss after UnknownHostException
2 participants