[knx] DPT 1 to support Switch and Contact #16238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow assigning Switch or Contact to most of the DPT 1 subtypes (exceptions 1.008 UpDownType, 1.010 StopMoveType, 1.022 DecimalType). * Tests for all published subtypes for DPT 1. * Fix sending of DPT 1.022. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
|
I guess this does not fix #9747, but does it in someway improve that? |
|
It does not, and this is intended. It allows to map DPTs that could previously be mapped to switch items also to be mapped to contact items. |
holgerfriedrich
added
the
enhancement
lsiepel
approved these changes
Jan 21, 2024
|
@lsiepel Thanks for asking. We do not state possible conversions in the README, just the default DPTs for the different types. So you could just go on.... |
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 27, 2024
* Allow assigning Switch or Contact to most of the DPT 1 subtypes (exceptions 1.008 UpDownType, 1.010 StopMoveType, 1.022 DecimalType). * Tests for all published subtypes for DPT 1. * Fix sending of DPT 1.022. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
ulbi
pushed a commit
to ulbi/openhab-addons
that referenced
this pull request
Jan 28, 2024
* Allow assigning Switch or Contact to most of the DPT 1 subtypes (exceptions 1.008 UpDownType, 1.010 StopMoveType, 1.022 DecimalType). * Tests for all published subtypes for DPT 1. * Fix sending of DPT 1.022. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: René Ulbricht <rene_ulbricht@outlook.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Allow assigning Switch or Contact to most of the DPT 1 subtypes (exceptions 1.008 UpDownType, 1.010 StopMoveType, 1.022 DecimalType). * Tests for all published subtypes for DPT 1. * Fix sending of DPT 1.022. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been initiated because of a discussion in the (German speaking) KNX User Forum.
DPT1 implementation had a rather strict mapping to types before. A Contact could not be used if the specific DPT was added to the group address definition
ga="1.011:<17/1/38", unless it was 1.009 or 1.019. As only subtypes 009 and 019 were mapped to OpenClosedType and the fallback for other DPTs was OnOffType,