Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Improve discovery result labels #16250

Merged
merged 1 commit into from Jan 9, 2024
Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 9, 2024

Discovery results for appliances can now be localized and model name is now included - e.g. "Dishwasher (G6895-W)".

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 9, 2024
@jlaur jlaur requested a review from kgoderis as a code owner January 9, 2024 21:13
@jlaur jlaur requested a review from a team January 9, 2024 21:14
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it localizable!

@wborn wborn merged commit cc0e802 into openhab:main Jan 9, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Jan 9, 2024
@jlaur jlaur deleted the miele-discovery branch January 9, 2024 23:04
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants