Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Add configuration parameter for using iOS wake-up #16259

Merged
merged 6 commits into from Jan 15, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jan 11, 2024

The readme previously stated it did auto detection of iOs device, but to me it seemed hardcoded. I changed this to a configurable option as some IoT devices can't handle the additional port knocking.

Test jar 4.2.0: https://1drv.ms/u/s!AnMcxmvEeupwjuUA88rQxWnsCUkymg?e=xXOno9

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Jan 11, 2024
@lsiepel lsiepel requested a review from a team January 11, 2024 19:46
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@wborn wborn changed the title [network] Make assumption iOs device configurable [network] Add configuration parameter for using iOS wake-up Jan 15, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 84d4dd3 into openhab:main Jan 15, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Jan 15, 2024
@lsiepel lsiepel deleted the network-ios-default-yes branch January 15, 2024 23:20
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
…16259)

Fixes openhab#9575

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…16259)

Fixes openhab#9575

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Network] ping causes udp port 5353 unreachable
4 participants