[Meteostick] Add windvane calibration #16270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiepel
added
the
enhancement
lsiepel
requested changes
Jan 14, 2024
bundles/org.openhab.binding.meteostick/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/openhab/binding/meteostick/internal/handler/MeteostickSensorHandler.java
Show resolved
Hide resolved
...ostick/src/main/java/org/openhab/binding/meteostick/internal/MeteostickBindingConstants.java
Outdated
Show resolved
Hide resolved
|
For some reason I did not commit and push all changes. Although the README was changed to include the "rain-today" channel, the code change for this channel was not included in the commit/push/pull. Will do a rebase, add commit and repush. |
Chiuaua79
force-pushed
the
main
branch
3 times, most recently
from
28044ff
to
74010cc
Compare
lsiepel
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM, @cdjackson would be nice if you can comment as codeowner.
|
Had to push once more as apparently the channel for rain-today was not showing up in the binding due to missing info in OH-INF/i18n/meteostick.properties and OH-INF/thing/thing-types.xml. Fixed these files as well to show the new channel (tested in my production OH server at home). |
lsiepel
requested changes
Feb 5, 2024
bundles/org.openhab.binding.meteostick/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
The Davis wind vanes 6410, 7911 and 7914 are mounted to a flat surface on the shaft. To ensure correct orientation of the wind vane, the anemometer must be mounted so that the arm points true north. This is not always possible. In these cases the wind direction must be calibrated. This commit adds the option to enter the direction the arm is facing and the binding will recalculate the wind direction as received from the Meteostick before publishing to the relevant channel. Furthermore in my opinion one rain channel was missing: accumulative rainfall for the current date. Added this channel, which required some code changes (adding of cronScheduler so the value is reset at midnight of the selected timezone). Tried to improve the code. Signed-off-by: Cor Hoogendoorn <chiuaua@hotmail.com>
In other commit mentioned adding daily rain accumulation but forgot to add the code. This commit adds the code for the daily rain accumulation channel. Signed-off-by: Cor Hoogendoorn <chiuaua@hotmail.com>
In previous commit did not add the channel for daily accumulated rain. Fixed with this commit. Signed-off-by: Cor Hoogendoorn <chiuaua@hotmail.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Cor Hoogendoorn <chiuaua@hotmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [Meteostick] Add windvane calibration * [Meteostick] Added daily rain accumulation Signed-off-by: Cor Hoogendoorn <chiuaua@hotmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. issue 16268
The Davis wind vanes 6410, 7911 and 7914 are
mounted to a flat surface on the shaft. To ensure
correct orientation of the wind vane, the
anemometer must be mounted so that the arm points
true north. This is not always possible. In these
cases the wind direction must be calibrated. This
commit adds the option to enter the direction the
arm is facing and the binding will recalculate the wind direction as received from the Meteostick
before publishing to the relevant channel.
Furthermore in my opinion one rain channel was
missing: accumulative rainfall for the current
date. Added this channel, which required some code changes (adding of cronScheduler so the value is
reset at midnight of the selected timezone). Tried to improve the code.