[tibber] Add time series support for Tibber prices #16275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
soenkekueper
added
the
enhancement
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
jlaur
requested changes
Jan 13, 2024
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
- extracted method for time series mapping - used ZonedDateTime.parse Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
jlaur
requested changes
Jan 14, 2024
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
jlaur
changed the title
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
jlaur
requested changes
Jan 14, 2024
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
|
I've rasied a PR to add the tibber icon in docs, as it is missing: |
|
Looks ok to me. |
Thanks for checking, let's merge then. |
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 27, 2024
Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addeds time series support for future tibber prices to openhab.
The values, that are currenty served as json data, are parsed and served as time series for the current total costs channel.