New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[http] Improve binding #16282
[http] Improve binding #16282
Conversation
This adds many improvements, new features and contains bugfixes. Signed-off-by: Jan N. Klug <github@klug.nrw>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the resubmission and many fixes and improvements! I have found a few things that are either new or that I missed previously.
...enhab.binding.http/src/main/java/org/openhab/binding/http/internal/HttpBindingConstants.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.http/src/main/java/org/openhab/binding/http/internal/HttpThingHandler.java
Outdated
Show resolved
Hide resolved
....binding.http/src/main/java/org/openhab/binding/http/internal/http/HttpResponseListener.java
Outdated
Show resolved
Hide resolved
...binding.http/src/main/java/org/openhab/binding/http/internal/http/RateLimitedHttpClient.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/HttpBindingConstants.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/HttpThingHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/http/HttpResponseListener.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/http/RateLimitedHttpClient.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for quickly addressing comments!
This adds many improvements, new features and contains bugfixes. Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This adds many improvements, new features and contains bugfixes. Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
This adds many improvements, new features and contains bugfixes.
Supersedes #15376