Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Improve binding #16282

Merged
merged 9 commits into from Jan 14, 2024
Merged

[http] Improve binding #16282

merged 9 commits into from Jan 14, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 14, 2024

This adds many improvements, new features and contains bugfixes.

Supersedes #15376

This adds many improvements, new features and contains bugfixes.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Jan 14, 2024
@J-N-K J-N-K requested a review from a team as a code owner January 14, 2024 20:18
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the resubmission and many fixes and improvements! I have found a few things that are either new or that I missed previously.

J-N-K and others added 7 commits January 14, 2024 21:52
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: J-N-K <github@klug.nrw>
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/HttpBindingConstants.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/HttpThingHandler.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/http/HttpResponseListener.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: J-N-K <github@klug.nrw>
…ding/http/internal/http/RateLimitedHttpClient.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: J-N-K <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quickly addressing comments!

@jlaur jlaur merged commit 0fe8d79 into openhab:main Jan 14, 2024
2 of 3 checks passed
@jlaur jlaur added this to the 4.2 milestone Jan 14, 2024
@J-N-K J-N-K deleted the http-new branch January 15, 2024 16:57
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
This adds many improvements, new features and contains bugfixes.

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
This adds many improvements, new features and contains bugfixes.

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants