Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http] Fix refresh time check and calculation #16288

Merged
merged 3 commits into from Jan 17, 2024
Merged

[http] Fix refresh time check and calculation #16288

merged 3 commits into from Jan 17, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 15, 2024

@J-N-K
[http] Fix refresh time check and calculation
3b6f90d 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jan 15, 2024
@J-N-K J-N-K requested a review from a team as a code owner January 15, 2024 18:03
jlaur
jlaur requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just one clarification needed (and please also apply spotless).

...ab.binding.http/src/main/java/org/openhab/binding/http/internal/http/RefreshingUrlCache.java Outdated Show resolved Hide resolved
@J-N-K
spotless
5a97f9e 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
address review comments
2de2c1e 
Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
jlaur approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 06b8c73 into openhab:main Jan 17, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Jan 17, 2024
@J-N-K J-N-K deleted the http-refresh branch January 17, 2024 20:27
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
@J-N-K @andrasU
[http] Fix refresh time check and calculation (openhab#16288)
4521264 
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@J-N-K @austvik
[http] Fix refresh time check and calculation (openhab#16288)
ab97dc6 
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@J-N-K @jlaur