[shelly] Add check and ThingStatus for local IP issue (APIPA) #16306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assignment failed. Avoid that the binding passes this address to the device as part of the callback url. Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added
the
enhancement
Signed-off-by: Markus Michels <markus7017@gmail.com>
lsiepel
requested changes
Jan 21, 2024
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/i18n/shelly.properties
Outdated
Show resolved
Hide resolved
lsiepel
changed the title
lsiepel
reviewed
Jan 21, 2024
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
|
@lsiepel requested changes applied |
ulbi
pushed a commit
to ulbi/openhab-addons
that referenced
this pull request
Jan 28, 2024
…b#16306) * Check for local_ip == 169.254.x.xm, which is the result when DHCP IP assignment failed. Avoid that the binding passes this address to the device as part of the callback url. Signed-off-by: Markus Michels <markus7017@gmail.com> Co-authored-by: markus7017 <markus7017@gmail..com> Signed-off-by: René Ulbricht <rene_ulbricht@outlook.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…b#16306) * Check for local_ip == 169.254.x.xm, which is the result when DHCP IP assignment failed. Avoid that the binding passes this address to the device as part of the callback url. Signed-off-by: Markus Michels <markus7017@gmail.com> Co-authored-by: markus7017 <markus7017@gmail..com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding checks now the local ip to be != 169.254.x.x, which is the result of a failed DHCP assignment. The framework reports this in the list of interfaces and the binding had send this to the device as part of the callback url, which resulted in device functioning in general, but the binding is not receiving any events. Now the user sees a WARNING is the log, which is a clear indicator of a setup to be fixed.