Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[growatt] Suggest addon to be installed #16319

Merged
merged 3 commits into from Feb 4, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jan 23, 2024

Suggest the addon to be installed.

(Also fixes a formatting error in readme file).

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Jan 23, 2024
@andrewfg andrewfg self-assigned this Jan 23, 2024
@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Jan 31, 2024
@andrewfg andrewfg requested a review from a team February 3, 2024 14:39
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 8d9fe03 into openhab:main Feb 4, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Feb 4, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [growatt] Suggest addon
* [growatt] fix read me formatting errors

---------

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants