[ipcamera] Improve online/offline detection for ONVIF cameras #16332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove commented out code. Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah
added
the
enhancement
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Remove commented out code. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better support for checking online and offline when the camera is an ONVIF type.
Changes should now allow for edge cases where an ONVIF camera has no snapshot and hence no http server to use for checking online status.
Also should allow for cameras that do not support ONVIF events, so they fall back to the proven method of opening a HTTP connecting to the configured port.
Cameras that have working ONVIF event streams will not try additional methods as the open stream proves the camera is already online.