Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Add support for Shelly Plus Mini Gen 3 series of devices, Shelly Plus UNI #16335

Merged
merged 1 commit into from Feb 4, 2024
Merged

[shelly] Add support for Shelly Plus Mini Gen 3 series of devices, Shelly Plus UNI #16335

merged 1 commit into from Feb 4, 2024

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Jan 28, 2024 •
edited

Add support for

  • Shelly Plus Mini genration 3 series of devices
  • Shelly Plus UNI
  • Shelly BLU Gateway

Closing

@markus7017
Support for Shelly Plus Mini Gen 3 series of devices, Shelly Plus UNI
52ea351 
and Shelly BLU Gateway.

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Jan 28, 2024
@markus7017 markus7017 self-assigned this Jan 28, 2024
This was linked to issues Jan 28, 2024
[shelly] Support for Shelly Plus Mini Series Gen 3 #15990
Closed
[shelly] Support for Shelly Plus UNI device #15991
Closed
[shelly] Support for Shelly BLU Gateway #15992
Closed
@markus7017 markus7017 mentioned this pull request Jan 28, 2024
Closed
@markus7017 markus7017 removed the work in progress A PR that is not yet ready to be merged label Jan 28, 2024
@markus7017
Copy link
Contributor Author

@lsiepel could we start here?

@lolodomo
Copy link
Contributor

lolodomo commented Feb 4, 2024 •
edited

Just one question about renamed properties entries.

@lolodomo lolodomo merged commit 3fb5e66 into openhab:main Feb 4, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Feb 4, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-1pm-mini-gen3/154185/4

@jlaur jlaur changed the title [shelly] Support for Shelly Plus Mini Gen 3 series of devices, Shelly Plus UNI [shelly] Add support for Shelly Plus Mini Gen 3 series of devices, Shelly Plus UNI Mar 3, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@markus7017 @austvik
Support for Shelly Plus Mini Gen 3 series of devices, Shelly Plus UNI (…
5e8f604 
…openhab#16335)

and Shelly BLU Gateway.

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@sfussenegger
Copy link

Would it be possible to get a backport to 4.1 while 4.2 isn't released? It seems to me that plenty of Shelly Gen3 will be shipped before 4.2 will be ready (is there even a date yet?).

Or would you be willing to accept a PR? I've tried git cherry-pick 3fb5e66eb1e87a9b626c1d7c87515c802814cbd5 into 4.1.x and it seemingly applied just fine (including mvn clean install -pl :org.openhab.binding.shelly with just a minor formatting issue in pom.xml). I was about to open a PR but you guys really emphasize not doing that so I didn't.

Thanks!

@lolodomo
Copy link
Contributor

4.2 should be available at end of June (we release a new version every 6 months).
A first milestone for 4.2 is already released. Looks like the best option for you.

@hal295
Copy link

hal295 commented May 7, 2024

Hi, could you please add support for pulse counter of Shelly Plus UNI? I dont see it in channels.
I would be very grateful. Thanks a lot for this binding!

@lsiepel
Copy link
Contributor

lsiepel commented May 7, 2024

Plus UNI

Please create an issue and ping markus7017 as i remember he usually creates the most PR's for shelly and is willing to add stuff as long as you are available to test and provide details for his development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo left review comments

@lsiepel lsiepel Awaiting requested review from lsiepel

Assignees

@markus7017 markus7017

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
6 participants
@markus7017 @lolodomo @openhab-bot @sfussenegger @hal295 @lsiepel