Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] New channel group ncurrent for 3EM #16336

Merged
merged 8 commits into from Feb 17, 2024

Conversation

markus7017
Copy link
Contributor

This PR adds new channels for 3EM's Neutral Current readings

Closing

@markus7017 markus7017 self-assigned this Jan 28, 2024
@markus7017 markus7017 added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Jan 28, 2024
markus7017 and others added 5 commits February 11, 2024 23:16
status and CoAP update (ncurrent only, no other values)

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 removed the work in progress A PR that is not yet ready to be merged label Feb 16, 2024
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 changed the title [shelly] Implement new channel group ncurrent for 3EM [shelly] New channel group ncurrent for 3EM Feb 16, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 4ca013d into openhab:main Feb 17, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Feb 17, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/3720

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* Add channels for emeter_n (neutral current-based measurements) - polled
status and CoAP update (ncurrent only, no other values)

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shelly] Support for 3EM's neutral current measurements (channel group ncurrent)
3 participants