-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plex] Add ratingKey channels #16343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useful for automations related to exactly what's playing, to avoid having to lookup based on title (which may not be unique) Signed-off-by: Cody Cutrer <cody@cutrer.us>
mlobstein
requested changes
Jan 30, 2024
....binding.plex/src/main/java/org/openhab/binding/plex/internal/handler/PlexPlayerHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.plex/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
@aronbeurskens please review also |
…ding/plex/internal/handler/PlexPlayerHandler.java Co-authored-by: mlobstein <github@lobstein.org> Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
mlobstein
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aronbeurskens
approved these changes
Jan 31, 2024
lolodomo
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [plex] add ratingKey channels useful for automations related to exactly what's playing, to avoid having to lookup based on title (which may not be unique) --------- Signed-off-by: Cody Cutrer <cody@cutrer.us> Co-authored-by: mlobstein <github@lobstein.org> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for automations related to exactly what's playing, to avoid having to lookup based on title (which may not be unique). I use this to lookup the aspect ratio of the currently playing title in a database, and adjust my constant-image-height screen appropriately.