Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plex] Add ratingKey channels #16343

Merged
merged 3 commits into from
Feb 4, 2024
Merged

[plex] Add ratingKey channels #16343

merged 3 commits into from
Feb 4, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jan 30, 2024

Useful for automations related to exactly what's playing, to avoid having to lookup based on title (which may not be unique). I use this to lookup the aspect ratio of the currently playing title in a database, and adjust my constant-image-height screen appropriately.

useful for automations related to exactly what's playing, to avoid
having to lookup based on title (which may not be unique)

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@mlobstein
Copy link
Contributor

@aronbeurskens please review also

ccutrer and others added 2 commits January 30, 2024 16:33
…ding/plex/internal/handler/PlexPlayerHandler.java

Co-authored-by: mlobstein <github@lobstein.org>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Copy link
Contributor

@mlobstein mlobstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 31, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 8d8e169 into openhab:main Feb 4, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Feb 4, 2024
@jlaur jlaur changed the title [plex] add ratingKey channels [plex] Add ratingKey channels Feb 4, 2024
@ccutrer ccutrer deleted the plex-ratingKey branch February 4, 2024 15:15
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [plex] add ratingKey channels

useful for automations related to exactly what's playing, to avoid
having to lookup based on title (which may not be unique)

---------

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Co-authored-by: mlobstein <github@lobstein.org>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants