Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Replace gnu.io dependency with serial transport #16376

Merged
merged 7 commits into from Feb 5, 2024

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Feb 5, 2024

This PR uses a new version of openwebnet4j lib (0.12.0) to avoid dependency of the binding on gnu.io.

Implementation

Version 0.12.0 of the openwebnet4j lib defines a new SerialPortProvider interface to discover and interact with serial ports.

With this PR the binding now provides a SerialPortProviderAdapter implementation of openwebnet4j's SerialPortProvider based on OH Serial Transport to provide serial port access to the lib, thus making the binding independent from gnu.io.

It has been tested extensively in a real environment with the Zigbee serial-USB dongle integrated by the binding.

Related to #7573

…n instead of returning @nullable

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
handling.

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
…Use own4j 0.12.0

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla added the enhancement An enhancement or new feature for an existing add-on label Feb 5, 2024
@mvalla mvalla requested a review from wborn February 5, 2024 14:51
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! 👍 It's nice to see that it only adds a very thin abstraction layer to be able to use different serial implementations with openwebnet4j. 🙂

@wborn wborn merged commit 3c53e1f into openhab:main Feb 5, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Feb 5, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…#16376)

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@mvalla mvalla deleted the openwebnet-replace-gnu.io-dependency branch April 14, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants