Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[growatt] Correct battery display channel unit from 'one' to 'volt' #16377

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[growatt] Correct battery display channel unit from 'one' to 'volt' #16377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...b.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/GrowattChannels.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public UoM(Unit<?> units, float divisor) {
new AbstractMap.SimpleEntry<String, UoM>("battery-type", new UoM(Units.ONE, 1)),
new AbstractMap.SimpleEntry<String, UoM>("battery-voltage", new UoM(Units.VOLT, 10)),
new AbstractMap.SimpleEntry<String, UoM>("battery-temperature", new UoM(SIUnits.CELSIUS, 10)),
new AbstractMap.SimpleEntry<String, UoM>("battery-display", new UoM(Units.ONE, 10)),
new AbstractMap.SimpleEntry<String, UoM>("battery-display", new UoM(Units.VOLT, 10)),
new AbstractMap.SimpleEntry<String, UoM>("battery-soc", new UoM(Units.PERCENT, 1)),

// fault codes
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ thing-type.growatt.bridge.description = Bridge Thing for Growatt Binding
thing-type.growatt.inverter.label = Growatt Inverter
thing-type.growatt.inverter.description = Inverter Thing for Growatt Binding
thing-type.growatt.inverter.channel.battery-display.label = Battery Display
thing-type.growatt.inverter.channel.battery-display.description = Battery display code.
thing-type.growatt.inverter.channel.battery-display.description = Battery display voltage.
thing-type.growatt.inverter.channel.battery-soc.label = Battery Charge
thing-type.growatt.inverter.channel.battery-soc.description = Battery state of charge.
thing-type.growatt.inverter.channel.battery-temperature.label = Battery Temperature
Expand Down
4 changes: 2 additions & 2 deletions bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,9 @@
<label>Battery Voltage</label>
<description>Battery voltage.</description>
</channel>
<channel id="battery-display" typeId="advanced-status-code">
<channel id="battery-display" typeId="advanced-electric-voltage">
<label>Battery Display</label>
<description>Battery display code.</description>
<description>Battery display voltage.</description>
</channel>
<channel id="battery-soc" typeId="advanced-percent">
<label>Battery Charge</label>
Expand Down