Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Fix last cleaning details wrong start and end missing issue #16388

Merged
merged 1 commit into from Feb 9, 2024

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Feb 9, 2024

closes #16005

Fixes missing end timestamp and wrong start timestamp

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv requested a review from jlaur February 9, 2024 08:24
@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Feb 9, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/miio-binding-roborock-s4max-no-longer-getting-last-cleaning-details/153260/14

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit dd6d8c1 into openhab:main Feb 9, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Feb 9, 2024
ulbi added a commit to ulbi/openhab-addons that referenced this pull request Feb 10, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@marcelrv marcelrv deleted the miio-endtime branch May 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] Roborock "Cleaning Start" shows "Cleaning End"
3 participants