[solax] Add support for x1 mini inverter local connection #16412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skeleton of the required classes for supporting X1 mini Add the parser data Fix build errors, headers and stuff Fixed parsing of raw data as per stakeholder response Fix error handling in the Cloud connection handler More fixes in the X1 parsing + a test for it Fix error handling in the Cloud connection handler Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
theater
added
enhancement
jlaur
changed the title
|
I have a confirmation from the community that the changes work as expected so this PR is ready for a review. Thanks in advance, |
jlaur
changed the title
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Skeleton of the required classes for supporting X1 mini Add the parser data Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for yet another inverter upon user request.
Extracted the common logic for the local wi-fi connect inverter tests into an abstract class, so only the values are compared in the child test classes.
Waiting for user confirmation that everything works after the cherry pick on top of the main branch's last major merge in the addon and then will remove the WIP label.
Best regards,
Konstantin