New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Support for Shelly BLU H&T #16413
Conversation
...lly/src/main/java/org/openhab/binding/shelly/internal/provider/ShellyChannelDefinitions.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/scripts/oh-blu-scanner.js
Outdated
Show resolved
Hide resolved
@clinique Review changes are applied |
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
eed9711
to
c28a945
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
...lly/src/main/java/org/openhab/binding/shelly/internal/provider/ShellyChannelDefinitions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Markus Michels <markus7017@gmail.com>
@lsiepel changes applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
* Support for Shelly BLU H&T added Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
This PR adds support for the Shelly BLU H&T sensor device