New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Add support for Range Extender feature #16419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor code modifications
...binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api1/Shelly1ApiJsonDTO.java
Show resolved
Hide resolved
...binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiJsonDTO.java
Show resolved
Hide resolved
...binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiJsonDTO.java
Show resolved
Hide resolved
...binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiJsonDTO.java
Show resolved
Hide resolved
...binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiJsonDTO.java
Show resolved
Hide resolved
...helly/src/main/java/org/openhab/binding/shelly/internal/config/ShellyThingConfiguration.java
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/shelly/internal/discovery/ShellyBasicDiscoveryService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/shelly/internal/discovery/ShellyBasicDiscoveryService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/shelly/internal/discovery/ShellyBasicDiscoveryService.java
Outdated
Show resolved
Hide resolved
@clinique changes applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the added support also refactors the discovery, i think it is good to be sure it is well tested to prevet regressions. Otherwise loogs good, left some minor comments.
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/config/config2.xml
Show resolved
Hide resolved
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/shelly/internal/discovery/ShellyBasicDiscoveryService.java
Outdated
Show resolved
Hide resolved
...helly/src/main/java/org/openhab/binding/shelly/internal/config/ShellyThingConfiguration.java
Show resolved
Hide resolved
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
e57967e
to
d55b1bc
Compare
@lsiepel changed applied + rebase |
@lsiepel anything open? |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
* Add support for Shelly Range Extender mode (Plus/Pro series only) * Check for secondary devices also when manual scan is triggered Signed-off-by: Markus Michels <markus7017@gmail.com>
* Add support for Shelly Range Extender mode (Plus/Pro series only) * Check for secondary devices also when manual scan is triggered Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
The Plus and Pro series have the so called Range Extender feature. In this case a Shelly could connect to another Shelly having this feature enabled as hub device via the access point of the hub device. The hub device then acts as a bridge between the host application (OH) and the linked device, which would not be able to connect to OH, because of missing WiFi coverage.