Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Add support for Range Extender feature #16419

Merged
merged 5 commits into from Mar 31, 2024

Conversation

markus7017
Copy link
Contributor

The Plus and Pro series have the so called Range Extender feature. In this case a Shelly could connect to another Shelly having this feature enabled as hub device via the access point of the hub device. The hub device then acts as a bridge between the host application (OH) and the linked device, which would not be able to connect to OH, because of missing WiFi coverage.

@markus7017 markus7017 added the enhancement An enhancement or new feature for an existing add-on label Feb 16, 2024
@markus7017 markus7017 self-assigned this Feb 16, 2024
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code modifications

@markus7017
Copy link
Contributor Author

@clinique changes applied

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the added support also refactors the discovery, i think it is good to be sure it is well tested to prevet regressions. Otherwise loogs good, left some minor comments.

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@lsiepel changed applied + rebase

@markus7017
Copy link
Contributor Author

markus7017 commented Feb 21, 2024

@lsiepel anything open?

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/3720

@jlaur jlaur changed the title [shelly] Support for Range Extender feature [shelly] Add support for Range Extender feature Mar 4, 2024
@markus7017
Copy link
Contributor Author

@lsiepel @clinique Anything open?

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit afc6d94 into openhab:main Mar 31, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Mar 31, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/3772

lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
* Add support for Shelly Range Extender mode (Plus/Pro series only)
* Check for secondary devices also when manual scan is triggered

Signed-off-by: Markus Michels <markus7017@gmail.com>
adr001db pushed a commit to adr001db/openhab-addons that referenced this pull request May 12, 2024
* Add support for Shelly Range Extender mode (Plus/Pro series only)
* Check for secondary devices also when manual scan is triggered

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants