Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[evcc] Fix capacity and vehicleName channels, Add current Vehicle/HeatingDevice per Loadpoint #16428

Merged
merged 5 commits into from Mar 8, 2024
Merged

[evcc] Fix capacity and vehicleName channels, Add current Vehicle/HeatingDevice per Loadpoint #16428

merged 5 commits into from Mar 8, 2024

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux MikeTheTux commented Feb 19, 2024 •
edited

  1. Fixed channels vehicle/capacity (bugfix)
    • Capacity channel is under vehicle and no longer under loadpoint since evcc 0.123.1
  2. Fixed channel vehicle/vehicleName (bugfix)
    • Update was done using a wrong channelUID
  3. Added channels for current Vehicle/HeatingDevice per Loadpoint (enhancement)
    • The new ChannelGroup provides direct access to the vehicle/heating device connected to the loadpoint without the indirection using the vehicleName
    • Example:
      • Access vehicle title in a rule before this PR:
        • const vehicleTitle = items.getItem("evcc" + items.evccLoadpoint0_VehicleName.state + "_VehicleTitle").state;
      • Now:
        • const vehicleTitle = items.evccLoadpoint0CurrentVehicle_VehicleTitle.state;
        • Users with a big fleet of vehicles will benefit allot. Because they must no longer add each single vehicle as items.

@MikeTheTux
removed loadpoint/vehicleCapacity, added vehicle/capacity (bugfix)
d5e3d71 
implemented currentVehicle / currentHeating per loadpoint (enhancement)
fixed update of channeld vehicleTitle (bugfix)

Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux
Copy link
Contributor Author

MikeTheTux commented Feb 19, 2024 •
edited

In addition I found a channelGroupTypeRegistry as well as channelGroupTypeRegistry. It should be possible to generate dynamic channelGroupTypes. Did not yet spot a good example ...

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Feb 19, 2024
@MikeTheTux
Copy link
Contributor Author

In addition I found a channelGroupTypeRegistry as well as channelGroupTypeRegistry. It should be possible to generate dynamic channelGroupTypes. Did not yet spot a good example ...

Examples are available in #14954

As this PR includes 2 bug-fixes, I would propose to get this PR merged as soon as possible and #14954 can be implemented as enhancement in another PR.

@lsiepel
Copy link
Contributor

lsiepel commented Feb 24, 2024

As a channel is moved, i would expect that a thing upgrade instruction or update notice is needed.

@MikeTheTux
Copy link
Contributor Author

As a channel is moved, i would expect that a thing upgrade instruction or update notice is needed.

This should already be covered by openhab/openhab-distro#1634

@MikeTheTux
mvn i18n:generate-default-translations -pl :org.openhab.binding.evcc
4a6a354 
Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux
separated vehicleFeatureHeating from loadpointFeatureHeating (theoret…
32bad3c 
…ical name clash)

Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux
shortened labels
61ffc71 
Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux
mvn i18n:generate-default-translations -pl :org.openhab.binding.evcc
1a1f11f 
Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux
Copy link
Contributor Author

It would be great if we could complete the review and bring this one into openHAB 4.2. would combine two breaking changes into a single release ...

lsiepel
lsiepel approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit b423933 into openhab:main Mar 8, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Mar 8, 2024
@lsiepel lsiepel changed the title [evcc] fixed channels vehicle/capacity and vehicle/vehicleName, added channels for current Vehicle/HeatingDevice per Loadpoint [evcc] Fix capacity and vehicleName channels, Add current Vehicle/HeatingDevice per Loadpoint Mar 8, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@MikeTheTux @austvik
[evcc] fixed channels vehicle/capacity and vehicle/vehicleName, added…
3085896 
… channels for current Vehicle/HeatingDevice per Loadpoint (openhab#16428)

* removed loadpoint/vehicleCapacity, added vehicle/capacity (bugfix)
implemented currentVehicle / currentHeating per loadpoint (enhancement)
fixed update of channeld vehicleTitle (bugfix)

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@MikeTheTux MikeTheTux mentioned this pull request Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on (potentially) not backward compatible
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeTheTux @lsiepel