Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecotouch] Add water and heating power limit channels #16446

Merged
merged 15 commits into from Mar 4, 2024
Merged

[ecotouch] Add water and heating power limit channels #16446

merged 15 commits into from Mar 4, 2024

Conversation

troem
Copy link
Contributor

@troem troem commented Feb 22, 2024 •
edited

[ecotouch] Limit power for heatpump

Addition of 4 new channels for limiting the power of the heatpump
Percent Water Power limit Min
Percent Water Power limit Max
Percent Heating Power limit Min
Percent Heating Power limit Min

@troem troem marked this pull request as ready for review February 22, 2024 16:09
@troem troem requested a review from sibbi77 as a code owner February 22, 2024 16:09
@troem troem changed the title limit power compressor flags for water and heating [ecotouch] limit power compressor flags for water and heating Feb 22, 2024
lsiepel
lsiepel requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Please also provide Thing upgrade instructions: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

Edit: it also needs spotless and the commits needs to be signed off.

bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/i18n/ecotouch_de.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/i18n/ecotouch.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 22, 2024
@lsiepel lsiepel changed the title [ecotouch] limit power compressor flags for water and heating [ecotouch] Add water and heating power limit channels Feb 22, 2024
@troem
Copy link
Contributor Author

troem commented Feb 27, 2024

Left some comments. Please also provide Thing upgrade instructions: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

Edit: it also needs spotless and the commits needs to be signed off.

OK - thank you for all your comments - I tried to do all my homework now and followed your instructions. This is my very first pull request and I am sorry heaving not read all documents carefully enough. Thank you for your time!

tobiroemer added 9 commits February 27, 2024 18:48
limit power compressor flags for water and heating
c741a56 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
typo in description fixed
00cf521 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
labels shortened
7a46db2 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
file generated by i18n
3df96b9 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
revert translation change
42b8100 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
channels added to geo and air
1029d5d 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>

Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
update instructions added
7a8d96a 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>

Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
Instructions added
3f886fa 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
line endings removed by spotless
bc1a152 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
lsiepel
lsiepel requested changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments.

After the labels have been adjusted also run the i18n plugin again to generate the properties file.

Regarding the thing-type instructions one last bit is missing. Add this to both Thing's. Doc here: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

<properties>
    <property name="thingTypeVersion">1</property>
  </properties>

bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
troem and others added 6 commits March 4, 2024 17:13
@troem @lsiepel
Update bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF…
753e583 
…/thing/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: troem <34965481+troem@users.noreply.github.com>
@troem @lsiepel
Update bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF…
90ec642 
…/thing/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: troem <34965481+troem@users.noreply.github.com>
@troem @lsiepel
Update bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF…
c32a34f 
…/thing/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: troem <34965481+troem@users.noreply.github.com>
@troem @lsiepel
Update bundles/org.openhab.binding.ecotouch/src/main/resources/OH-INF…
cb9bd0b 
…/thing/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: troem <34965481+troem@users.noreply.github.com>
i18n translation
839a94b 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
thingTypeVersion added
cf01ee5 
Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
@troem
Copy link
Contributor Author

troem commented Mar 4, 2024

Some final comments.

After the labels have been adjusted also run the i18n plugin again to generate the properties file.

Regarding the thing-type instructions one last bit is missing. Add this to both Thing's. Doc here: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

<properties>
    <property name="thingTypeVersion">1</property>
  </properties>

Some final comments.

After the labels have been adjusted also run the i18n plugin again to generate the properties file.

Regarding the thing-type instructions one last bit is missing. Add this to both Thing's. Doc here: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

<properties>
    <property name="thingTypeVersion">1</property>
  </properties>

Done with cf01ee5
Thank you for your review

@troem troem closed this Mar 4, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Mar 4, 2024

Did you close this on purpose?

@troem
Copy link
Contributor Author

troem commented Mar 4, 2024

Did you close this on purpose?

So I thought I did all my homework, obviously I created a mess, I am sorry. I saw the "Closed with unmerged commits" but I did not find a way to merge / to solve this situation ... could you give me a hint, please?

@troem troem reopened this Mar 4, 2024
lsiepel
lsiepel approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit fb26d0e into openhab:main Mar 4, 2024
4 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Mar 4, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@troem @austvik
[ecotouch] Add water and heating power limit channels (openhab#16446)
b37e221 
* limit power compressor flags for water and heating

Signed-off-by: tobiroemer <bitbucket.org@t-obias.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@troem @lsiepel