Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] Fix DPT 6.020 and 8.010 #16453

Merged
merged 1 commit into from Feb 25, 2024
Merged

Conversation

holgerfriedrich
Copy link
Member

Findings from Back2Back test:

DPT 6.020 uses a StringType representation in Calimero. Added StringType to allowed types.

DPT 8.010 was depending on locale, as it renders numbers with fraction. Calimero expects decimal separator in current locale.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich added the bug An unexpected problem or unintended behavior of an add-on label Feb 24, 2024
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 51caca3 into openhab:main Feb 25, 2024
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone Feb 25, 2024
@holgerfriedrich holgerfriedrich deleted the pr-knx-fixdpts branch February 25, 2024 17:42
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants