Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fineoffsetweatherstation] Implement new Measurand free-heap-size #16461

Merged
merged 2 commits into from Feb 27, 2024
Merged

[fineoffsetweatherstation] Implement new Measurand free-heap-size #16461

merged 2 commits into from Feb 27, 2024

Conversation

Andy2003
Copy link
Contributor

@Andy2003 Andy2003 commented Feb 26, 2024 •
edited

[fineoffsetweatherstation] Implement new measurand free-stack-size

As discussed in the community thread this PR adds a new measurand free-stack-size which was introduced by protocol version 1.6.9

Testing

https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.fineoffsetweatherstation/4.2.0-SNAPSHOT/org.openhab.binding.fineoffsetweatherstation-4.2.0-SNAPSHOT.jar

@Andy2003 Andy2003 requested a review from jlaur February 26, 2024 16:48
@Andy2003 Andy2003 added the enhancement An enhancement or new feature for an existing add-on label Feb 26, 2024
@Andy2003 Andy2003 force-pushed the feature/fine-offset-weatherstation-update-protocol branch from 7f8c629 to 4f55d3f Compare February 26, 2024 16:51
@Andy2003
[fineoffsetweatherstation] Implement new measurand free-stack-size
32aa568 
Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
@Andy2003 Andy2003 force-pushed the feature/fine-offset-weatherstation-update-protocol branch from 4f55d3f to 32aa568 Compare February 26, 2024 16:59
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fine-offset-weather-station-binding-discussion/134167/268

@lsiepel
Copy link
Contributor

lsiepel commented Feb 26, 2024

What is free-stack-size in relation to this weather binding? It sounds like some internal technical memmory thing, but maybe i'm biased as programmer this has nothing to do with it?!

jlaur
jlaur reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some small clarifications needed.

...les/org.openhab.binding.fineoffsetweatherstation/src/main/resources/OH-INF/thing/gateway.xml Outdated Show resolved Hide resolved
....fineoffsetweatherstation/src/main/resources/OH-INF/i18n/fineoffsetweatherstation.properties Outdated Show resolved Hide resolved
@jlaur
Copy link
Contributor

jlaur commented Feb 26, 2024

What is free-stack-size in relation to this weather binding? It sounds like some internal technical memmory thing, but maybe i'm biased as programmer this has nothing to do with it?!

Sorry, I had not seen your comment, but it seems we were wondering about the same thing. 🙂

@Andy2003
Copy link
Contributor Author

What is free-stack-size in relation to this weather binding? It sounds like some internal technical memmory thing, but maybe i'm biased as programmer this has nothing to do with it?!

From the manufacturer:

hI,

This is for heap : the available stack top. If it is reducing, it means the stack is using up.

I have it attached for your reference.

Hope this helps.

Source: https://community.openhab.org/t/fine-offset-weather-station-binding-discussion/134167/266

@Andy2003
[fineoffsetweatherstation] adjustments after review
8832440 
Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
@Andy2003 Andy2003 force-pushed the feature/fine-offset-weatherstation-update-protocol branch from acde3bb to 8832440 Compare February 27, 2024 08:30
@Andy2003 Andy2003 requested a review from jlaur February 27, 2024 08:32
jlaur
jlaur approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur changed the title [fineoffsetweatherstation] Implement new Measurand free-stack-size [fineoffsetweatherstation] Implement new Measurand free-heap-size Feb 27, 2024
@jlaur jlaur merged commit b6366ab into openhab:main Feb 27, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Feb 27, 2024
@Andy2003 Andy2003 deleted the feature/fine-offset-weatherstation-update-protocol branch February 27, 2024 11:09
@lsiepel
Copy link
Contributor

lsiepel commented Feb 27, 2024 •
edited

I have read the community thread, but still wondering why one want to have this channel. Is it some sort of memmory leak detection? No problem to have this as advanced (as it is now), just a strange channel to have.

@Andy2003
Copy link
Contributor Author

The plugin reads out all available measurands. It is up to the user to decide which ones make sense for them.

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@Andy2003 @austvik
[fineoffsetweatherstation] Implement new Measurand free-heap-size (o…
2498dab 
…penhab#16461)

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andy2003 @openhab-bot @lsiepel @jlaur