[jythonscripting] Upgrade to Jython 2.7.3 #16465
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/jython-is-not-deprecated/154187/7 |
There was a problem hiding this comment.
Thanks for the upgrade! I'm wondering though if the deprecation warning should be removed. If I understand it correctly, Jython still only supports Python 2.7 which is (also) deprecated:
https://github.com/jython/jython/blob/master/README.md#support
Did anything change with regards to the helper library? Besides the point upgrade you have just contributed, Jython Scripting in openHAB still seems somewhat abandoned and probably some kind of warning is still justified, or..?
jlaur
changed the title
|
Agree, I think it's premature to remove the deprecation warning unless and until at least someone starts to show a willingness to start keeping the add-on up to date and such. There has been four years of changes to the OH API that this add-on doesn't take advantage of. I suspect there is some work needed here that someone could do to show a willingness to take on maintaining the add-on. It would be a miserable experience, but one can develop rules without a Helper Library. I personally would consider a Helper Library a prerequisite but technically it's not required. So a lack of an official library shouldn't keep us from removing the deprecated flag. But without someone keeping up the add-on, we are still in a situation that something may break and no one will be able or willing to fix it. Obviously though, if we can get a Helper Library an official part of the OH project and included in the add-on by default that would be awesome! |
|
There isn't much required inside the add-on. Currently it is fine as is. About the only thing that I think would be nice to change is the choice of default path. I'll keep it updated if and when there's a new jython version if nobody else does it. |
|
It's looking like @HolgerHees might be willing to take it on and work the Helper Library. Obviously it will take some time but between the two of you I'm comfortable removing the deprecation warning. |
* Upgrade to jython 2.7.3 * remove the deprecation notice in jython readme Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Remove the deprecation notice in jython readme
https://community.openhab.org/t/jython-is-not-deprecated/154187