Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keba] Add support for additional x-series wallboxes #16474

Merged
merged 3 commits into from Mar 11, 2024

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux MikeTheTux commented Mar 1, 2024

Fixed #16472.

The following wallboxes from the x-series are now supported as well:

  • x-series 4G, w/o LM: identified via S in the product designation string
  • x-series WLAN, w/o LM: identfied via U in the product designation string

Fixed type mapping for identifier 'A':

  • was x-series but actually is c-series

Test Build: org.openhab.binding.keba-4.2.0-SNAPSHOT-2024-03-01.zip

…nd "U" (WLAN, w/o LM)

Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux MikeTheTux changed the title [keba] Added support for additional Xx-series wallboxes [keba] Added support for additional x-series wallboxes Mar 1, 2024
@MikeTheTux
Copy link
Contributor Author

I added S and U to the list of supported device types, but did not delete A, C, D and G from the list, although they are not listed in kecontactp30_bden_web.pdf.
Does anyone know, what the identifier of the BMW wallbox is?

309297702-70e79885-6de8-4b09-bbbb-5d3068835931

@MikeTheTux MikeTheTux requested a review from lolodomo March 1, 2024 18:45
@MikeTheTux
Copy link
Contributor Author

@Andre1Becker found it in a different manual page 8 :

309446937-cd521cfa-42a2-43f2-aa52-e9d147ceda38

A, C, D is now clarified as well.

A is a c-series, but implemented as x-series right now:

        E('0'),
        B('1'),
        C('2'),
        A('3'),
        X('A', 'B', 'C', 'D', 'E', 'G', 'H', 'S', 'U');

G is still unclear. BMW wallbox?
What about the Company Car wallbox or PV-Edition?

image

@MikeTheTux
Copy link
Contributor Author

I filed a support request at Keba, also asking for further info about the upcoming P40/P40pro.

@Andre1Becker
Copy link

G is still unclear. BMW wallbox? What about the Company Car wallbox or PV-Edition?

I've got this 'Dienstwagen-Edition' (Company Car Edition) so that should be covered. At least that specific version :-)

@Andre1Becker
Copy link

Andre1Becker commented Mar 2, 2024

I filed a support request at Keba, also asking for further info about the upcoming P40/P40pro.

I just noticed the P40 too.
That seems to be the best Idea to get all the Infos needed.

Have a sunny weekend!

    was x-series but actually is c-series.

Signed-off-by: Michael Weger <weger.michael@gmx.net>
'3' is P20 c-series + PLC but also P30 a-series - P30 a-series doesn't support the required UDS protocol

Signed-off-by: Michael Weger <weger.michael@gmx.net>
@jlaur jlaur changed the title [keba] Added support for additional x-series wallboxes [keba] Add support for additional x-series wallboxes Mar 2, 2024
@lolodomo
Copy link
Contributor

Is it ready for a merge ?

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Mar 11, 2024
@MikeTheTux
Copy link
Contributor Author

Is it ready for a merge ?

Please merge.

Until now, I did not receive any feedback on my support request at Keba. If there is an outcome that requires some changes in the binding, we can raise a new PR.

In the meanwhile I was able to find out the P40 product naming schema:

Still it is not clear, if the same UDP protocol is supported by the P40/P40pro / or not.

@lolodomo lolodomo merged commit a7d183e into openhab:main Mar 11, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KEBA] Scheduled runnable ended with an exception
3 participants